Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for tourism=gallery #3401

Merged
merged 2 commits into from
Oct 4, 2018
Merged

Add icon for tourism=gallery #3401

merged 2 commits into from
Oct 4, 2018

Conversation

Adamant36
Copy link
Contributor

@Adamant36 Adamant36 commented Sep 18, 2018

This PR adds rendering for tourism=gallery. Closes #883

Definition and Rational for Rendering

Although there are some people who think this tag is to vague etc, none of the arguments against it use where very strong, it was only a small number of people, and the tags usage has increased quit a lot in the 5 years since objections to it started. Plus, as I have been reminded multiple times myself, this isn't a place for a tagging discussions anyway. That being said, although the word "gallery" might not explicitly mean an art gallery in a general sense, it is clearly the definition given on the wiki page. To me personally an art gallery is clearly distinct from shop=art or tourism=museum in the fact that unlike them it is a place that only displays art but does not mainly do it for profit. Whereas an art shop sells art and a museum features other things besides art. The wiki page gives the same definition, but as I stated, this isn't the place for tagging/tag definition discussions anyway. Its about if the tag should be rendered or not and nothing against the tags definition is compelling enough to make me think it shouldn't be rendered. Not to mention there is no alternative tag for the places this one covers anyway. So its either the things get rendered as tourism=gallery or they never get rendered. I rather they get rendered.

As far as the benefits to rendering it, it has 5,168 uses and the uses are increasing rather rapidly. So there is clearly a market for it being rendered. Also, the items tagged as tourism=gallery don't currently have their names rendered on the map. Which creates rather large gaps on the map in places where multiple galleries are on the same block, like in Oakland where did the test rendering. Also, whatever museums or art shops are wrongly tagged as tourism=gallery will probably never be fixed if the tag is not rendered. since mappers wont know the places are on the map in the first place to fix them.
taghistory

Test Renderings

https://www.openstreetmap.org/#map=19/37.81541/-122.26658 (way)
way
https://www.openstreetmap.org/#map=19/37.81454/-122.26766 (node)
node

@Tomasz-W Tomasz-W mentioned this pull request Sep 18, 2018
26 tasks
@kocio-pl
Copy link
Collaborator

Also this PR needs some rationale and summary, please add them.

@dieterdreist
Copy link

dieterdreist commented Sep 18, 2018 via email

@Adamant36
Copy link
Contributor Author

Adamant36 commented Sep 20, 2018

@dieterdreist, I'm not really sure of any definition of a gallery outside of an art gallery and the wiki page is pretty clear to its definition. Plus, it seems more like a tagging question then a "why should this be rendered" question. That being said, I updated my original post to answer you anyway.

@lakedistrictOSM
Copy link

If possible, it would be good to use a different icon. The one currently proposed makes me think of a place where you can do art activities, like a children's arts centre or an artist's studios.

I think that a framed painting design might work better - here's one I made a while ago:
artdraft01png

If you like it, feel free to test it (I'll upload it to gist later) or just feel free to take inspiration from it.

@dieterdreist
Copy link

dieterdreist commented Sep 22, 2018 via email

@Adamant36
Copy link
Contributor Author

@dieterdriest, I semi agree with you. Although, Id say the places with permanent exibits are more like museums. Theres clearly a third category of places that have rotating displays but arent mainly in it to sell the art. The wiki makes the distinction and so does this guy (whoever he is) http://handmade-business.com/language-arts-theres-a-distinct-difference-between-a-gallery-and-a-shop-learn-what-it-is/

So the question do we follow the wiki and that guy by displaying galleries (how ever it might define it) on the map. Since theres clearly a bunch of "whatever you want to call them" things mapped..Or do we not display them because a slight ambiguity in the meaning of the word "gallery" might exist? If it was a new tag and hadnt already been dissussed id say dont render it until gets figured out at least. But the disscussions over it went know where in five years and the tag kept being used in ever increasing numbers. Its clear that the tag is one the community accepts and widely uses. So I think thats good enough to say it should be displayed.

@Adamant36
Copy link
Contributor Author

@kocio-pl, I don't get what the conflict here is. Is it the empty line at 2349 or something?

@dieterdreist
Copy link

dieterdreist commented Sep 24, 2018 via email

@Adamant36
Copy link
Contributor Author

Adamant36 commented Sep 24, 2018

I would consider a museum a place that houses collections of things, like artifacts, that are of historical or cultural importance. A lot of art in art galleries dont fit those categories and often one off paintings, instead of collections.

A lot of colleges have galleries that display art done by the students or other artists. They call themselves galleries. Theres also none profits that display art created by community members. Although they often call themselves "art centers," they still contain a gallery. There is also places like the Slate Contemporary in Oakland that has a gallery and a different building off site where the works are sold. Id imagine there are many places where the place that the is displayed is different then where its sold, or they just refer a buyer to an artist and get a cut later. Those places would be galleries in my opinion. As the transaction is done off site.

Whats ambiguous about "art shop" exactly?

I think the fluidity of the wiki can apply in many cases, not just this one. That's not a reason to not render galleries though. IMHO, its set in stone at least in the fact that the discussion over the current definition ended five years ago and nothing was modified based on it. No one switched over to another tag or anything. So maybe the minor details need to be ironed out, at least in your opinion, but that doesnt put the whole tag in question. So theres no reason to wait until its %100 decided to render it. You could also put up a "this key is in dispute" banner or something and start the conversation over again. Although I doubt it will go anywhere.

Its slight in the fact that theres only a few detractors, the tag is used a bunch, and it seems like there is clearly a third category if you think so or not. Even if it might be hard to pin down what exactly it is. While I agree with you that usage numbers shouldnt be an excuse for rendering a bad tag under normal conditions, I think it comes down to the fact that these things clearly exist even if its fuzzy as to what qualifies. They arent shops or museums though, they will probably never be tagged as those things because of the fuzzyness, and the fuzzyness isnt going to go away. So its better just to render them. Otherwise, your forcing something into a binary choice between museums or shops that it doesnt fit into. And you say shops are ambigious, which means every place displaying art should be a museum then? That doesn't sound right.

@dieterdreist
Copy link

dieterdreist commented Sep 24, 2018 via email

@Adamant36
Copy link
Contributor Author

@kocio-pl, what do you think about this one? I think dieterdreist makes some good points, but then I'd still like to see the places rendered on the map and galleries seem to be in enough of a gray area definition wise where I don't think they will ever get re-tagged as anything else. Even if a better tag for them comes along, which I don't see happening.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 4, 2018

Sorry for not following this, I have less time lately and there were more PRs to check and discuss.

I have just looked at https://wiki.openstreetmap.org/wiki/Tag:tourism%3Dgallery and it looks quite solid. It is approved tag and the difference from both shop=art and tourism=museum is defined. I understand it means special kind of museum - "art museum". I have no problem with it, since some real life categories are special while being part of more generic category (like shop=shoes is in fact kind of shop=clothes) and some common objects being split between tags in OSM (like historic=memorial and historic=monument).

@Adamant36
Copy link
Contributor Author

No worries. Its been pretty busy around here lately. So, thanks for looking into it. I totally agree with you. Since your good on it, I'll fix the conflicts when I have some time and wait for it to be merged.

@Adamant36
Copy link
Contributor Author

@kocio-pl, I fixed the conflicts. I also consolidated the code for a few amenities that had the same attributes while I was there. It seems to have passed Travis fine. So, its good to go.

@kocio-pl kocio-pl merged commit 5935bea into gravitystorm:master Oct 4, 2018
@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 4, 2018

Thanks! It works as expected in my test renderings.

@Adamant36 Adamant36 deleted the gallery branch October 4, 2018 12:26
@Adamant36
Copy link
Contributor Author

Awesome. Thanks for testing and merging it.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 4, 2018

I have found also examples of open air gallery and gallery of photos operated by photographic society - both are not the shop (not focused on selling) nor museum (not in the common meaning of the word), so this tag is really useful.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 6, 2018

@Tomasz-W What do you think about tweaking art center icon to show it different than galleries? We have different colors to show if it's retail gallery or not, but art center is wider (for example it can contain some gallery space inside). Maybe it would be good to make some kind of objects mix, like we have for shop=video or shop=music (maybe adding similar note symbol would work).

@Tomasz-W
Copy link

Tomasz-W commented Oct 6, 2018

@kocio-pl I'll try with palette + note icon.

@Tomasz-W
Copy link

Tomasz-W commented Oct 6, 2018

@kocio-pl Palette + note:

amenity arts_centre

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 6, 2018

Could you switch them (note on the left)?

@Tomasz-W
Copy link

Tomasz-W commented Oct 6, 2018

@kocio-pl

  • amenity arts_centre (switched)
  • amenity arts_centre2 (rotated palette)

@lakedistrictOSM
Copy link

I prefer the original one ( )

Alternatively, we could instead use a different icon for gallery and art shop, maybe something like the one I suggested in #3401 (comment) ( ).

BTW, you can't buy a painting palette at a shop=art, but you can at a shop=craft (arts and craft supplies shop, 5.1k uses) which doesn't have an icon yet.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 8, 2018

This could be also proper symbol for shop=frame:

taghistory 60

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 9, 2018

@Tomasz-W What about one theater mask with half of palette?

@Tomasz-W
Copy link

Tomasz-W commented Oct 9, 2018

@kocio-pl

  • amenity arts_centre1 (palette + note v1)
  • amenity arts_centre2 (palette + note v2)
  • amenity arts_centre3 (palette + mask)

Gist link: https://gist.github.com/Tomasz-W/fd50cec314d442d0f8a58863e3c818ec

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 9, 2018

Could someone make a test rendering for all these icons?

@lakedistrictOSM
Copy link

@Tomasz-W The mask is too small for me. How about mask + paintbrush, with a bigger mask?

@Tomasz-W
Copy link

Tomasz-W commented Oct 10, 2018

@lakedistrictOSM mask + brush looked weird, so I tried with note + brush:

amenity arts_centre4

vertical brush looked more like a torch, so I rotated it a little bit.

@Tomasz-W Tomasz-W mentioned this pull request Oct 14, 2018
@jeisenbe jeisenbe added new features Requests to render new features POI labels Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new features Requests to render new features POI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rendering for tourism=gallery
6 participants