Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for charity and second_hand and update department_store icon #3302

Merged
merged 3 commits into from
Jul 17, 2018
Merged

Conversation

jragusa
Copy link
Contributor

@jragusa jragusa commented Jul 13, 2018

Fixes #1869

Changes proposed in this pull request:

  • Render shop=charity and shop=second_hand
  • Update shop=department_store icon for consistency

Test rendering with links to the example places:
shop=charity
https://www.openstreetmap.org/way/80238885
shop_charity

shop=second_hand
https://www.openstreetmap.org/node/2872062455
shop_second_hand

shop=department_store
https://www.openstreetmap.org/way/124653217
Before
department_store_before

After
department_store_after

@kocio-pl
Copy link
Collaborator

Please test rendering for both nodes and ways (with name labels) for each case.

@Tomasz-W Tomasz-W mentioned this pull request Jul 13, 2018
26 tasks
@jragusa
Copy link
Contributor Author

jragusa commented Jul 14, 2018

@kocio-pl I confirm rendering for both nodes and ways, and with label name. Do you need screenshots ?

@kocio-pl
Copy link
Collaborator

Yes, please - the screenshots with links.

@kocio-pl kocio-pl merged commit 9198480 into gravitystorm:master Jul 17, 2018
@kocio-pl
Copy link
Collaborator

Thanks a lot! I did some cross-checking and it works as expected.

@jragusa jragusa deleted the charity branch November 8, 2018 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants