-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add special rendering for shop=charity #1869
Comments
An horizontal open hand is also often used as symbol for charity. |
I'll try it, thanks for the idea! In the meantime different take: |
Unfortunately none of the presented examples are very clear to me - what do others think? |
I still plan to test your idea, however had no time lately. |
Likewise. In order of preference, they would be 1, 2, and 3, but I don't like any of them. |
I guess this is not something worth exploring at this moment. |
Another way of looking at charity shops is that they are essentially a reuse/recycle point for clothes, books etc - what would the department_store icon look like if the & was replaced with the recycling icon (or a simplified version)? I'm having problem with Inkscape at the moment so can't test this myself. If this works it could be used for shop=second_hand too. (charity is now 5k and second_hand is 6k) |
I can't imagine it, so some real design would be needed to test it. Just the current recycle bin icon in violet would be probably not distinct enough. |
The right one looks quite good to me. Could you post a gist with them? |
I only saved a PNG version because I didn't like it - but it's basically just the department_store icon with the "&" replaced with the recycling icon, as big as it can be inside the bag shape. Sorry @kocio-pl ! |
@Tomasz-W What do you think about it? |
For me, some 'refresh' symbol would fit here better. A 'recycling' symbol is too much associated with ecology topic, so it may be confusing. http://simpleicon.com/wp-content/uploads/refresh.png I can try to combine it with bag shape for shop=charity and t-shirt shape for shop=second_hand |
Great, nice idea! So I reopen the issue. |
Both good designs, shop=charity is clearer for me. shop=second_hand don't necessarily sell clothes, four second_hand shops near me don't sell any clothes but mainly books, bric-a-brac and antiques. (This is in the UK, I imagine what a second_hand shop sells varies worldwide) I'd consider shop=charity and shop=second_hand to be more similar and therefore the same icon could be used for both. |
I agree with @lakedistrictOSM - the first icon is good, the second one looks less clear and maybe we could use it for |
@Tomasz-W Could you also make a version with a square handle like variety_store, just for comparison? |
sent from a phone
On 11. Mar 2018, at 13:41, lakedistrictOSM ***@***.***> wrote:
shop=second_hand don't necessarily sell clothes, four second_hand shops near me don't sell any clothes but mainly books, bric-a-brac and antiques. (This is in the UK, I imagine what a second_hand shop sells varies worldwide)
shop=second_hand is somehow the corresponding shop to department store, i.e. it sells more than one typology of goods, otherwise the wiki says you should use second_hand as a property
I'd consider shop=charity and shop=second_hand to be more similar ad therefore the same icon could be used for both.
“charity” is IMHO not a good category in general, as it remains unclear what they sell, it rather seems to refer to the operator type of the business.
|
(round handle) Both versions in this link: https://gist.github.com/Tomasz-W/23392e6d302279f419dcad435eb7de02 |
JOSM has an icon for charity shop: In my experience shop=charity represents a very distinct category of shops. I frequently visit several myself and in e.g. Denmark they are extremely common. |
Of course they are distinct (that's why we have different tags), but so is meadow, grass and grassland - yet we render them the same, because they are similar. Both shops usually sell used things and for depicting this fact the icon is relevant. |
I'm ok with using the same icon for both My rant was in response to
Being quite familiar with both types of shops I disagree with this. |
sent from a phone
On 12. Mar 2018, at 16:11, Michael Andersen ***@***.***> wrote:
Being quite familiar with both types of shops I disagree with this.
your text seems to confirm my statement though.
|
@dieterdreist Does the part of my text saying
confirm your statement? To me shop=charity is quite a useful category, as it tells me quite accurately what to expect when stepping into one of them. Consider shop=supermarket. You'll have to be familiar with 'supermarkets' to know what they are selling too, since the description doesn't directly indicate it (like i.e. shop=car does). They don't actually sell supermarkets. There's also quite a wide variety between individual supermarket chains (much more than between charity shops). Some will satisfy fairly basic everyday needs only, while larger ones sells i.e. clothes and furniture too. So, in order to know what to expect, you'll have to be familiar not only with the concept of 'supermarket', but also with individual chains. |
@Tomasz-W Good idea 👍 |
For consistency with |
|
Different shapes makes them easier to tell apart :-) |
Don't forget about Personally, I like the look of the round handles. |
@meased Indeed, I missed this icon. I agree with you. We should have the same pattern for all of these icons |
@jragusa Departament store icon on "square handle" template: Gist link: https://gist.github.com/Tomasz-W/85550c86782cc47def1d61fd033ca75b |
shop=charity has more than 2,5k uses and a wiki page. We already show it as a general dot.
My draft:
The text was updated successfully, but these errors were encountered: