Switching generic cemeteries to SVG #2716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocio-pl
force-pushed
the
cemetery-generic-svg
branch
from
1eb5fac to
1dcfecf
Compare
|
The pattern size needs to be some integer division of 256. btw, I did a cemetery pattern at https://github.com/kartotherian/brighmed/blob/master/symbols/patterns/cemetery.svg |
pnorman
requested changes
Jul 31, 2017
symbols/grave_yard_generic.svg
Outdated
| id="svg4" | ||
| viewBox="0 0 18 18" | ||
| height="18" | ||
| width="18" |
There was a problem hiding this comment.
To tile correctly, the tile size needs to be an integer multiple of the pattern size, so this needs to be a power of two
kocio-pl
force-pushed
the
cemetery-generic-svg
branch
from
1dcfecf to
9a3c8a3
Compare
|
Thanks! Brighmed pattern does not directly fit here: BTW: Interesting enough, current PNG version is 16x16. |
|
Not needed due to #2714 work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2045.
Warsaw, z19
Before
After