Switching jewish cemeteries to SVG #2715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnorman
requested changes
Jul 31, 2017
symbols/grave_yard_jewish.svg
Outdated
| version="1.1" | ||
| width="18" | ||
| height="18" | ||
| viewBox="0 0 18 18" |
There was a problem hiding this comment.
needs to be a multiple of 2, for the same reasons as #2716
symbols/grave_yard_jewish.svg
Outdated
| id="canvas" | ||
| style="visibility:hidden;fill:none;stroke:none" /> | ||
| <path | ||
| style="fill:#88b78e;fill-opacity:1;stroke-width:0.73192507" |
There was a problem hiding this comment.
It's best to not have stroke
kocio-pl
force-pushed
the
cemetery-jewish-svg
branch
from
bd315d7 to
bdae0ae
Compare
|
I guess stroke was not used anyway, but I removed it. Current PNG version is 18 px, but I've changed it to 16 px and now the pattern is a bit more dense: |
|
The icons look bolder now - is this accurate, or just perceptual? |
|
The color is the same and the size is rather similar, but current images are more blurred than new ones. |
|
Not needed due to #2714 work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2045.
Warsaw, z19
Before
After