Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow collisions with some symbols #1007

Closed
wants to merge 1 commit into from
Closed

allow collisions with some symbols #1007

wants to merge 1 commit into from

Conversation

matkoniecz
Copy link
Contributor

obvious situation with strong improvement

http://www.openstreetmap.org/?mlat=49.4712&mlon=21.3811#map=15/49.4712/21.3811

selection_011

really high gate density with some improvements and some regressions, overall effect is IMHO positive (and new problem may be almost certainly fixed by adding halo to street names)

http://www.openstreetmap.org/#map=16/50.0484/19.9300

selection_001

Fixes parts of #323 and #964

Likely also other symbols may benefit from similar change, but not all of them - see #982 (comment)

@mboeringa
Copy link

and new problem may be almost certainly fixed by adding halo to street names

that halo will indeed be vital for this. Without it, the names of the streets are completely illegible.

Looking at this particular example, I personally really feel the gates shouldn't be rendered before Z18, but that discussion has been going on elsewhere...

Once the halo is implemented, I think you made the most of a situation upon which no really good agreement and solution is possible.

@matthijsmelissen
Copy link
Collaborator

I think for unclassified/residential, adding halos is no problem.

For motorway/trunk/primary/secondary/tertiary, adding halo might decrease legibility.

@HolgerJeromin
Copy link
Contributor

For motorway/trunk/primary/secondary/tertiary we could use a halo in the color of the corresponding road fill. No visible changes in the normal case, but better readability if there is for example a gate underneath.

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this pull request Oct 4, 2014
* This increases the legibility of labels in certain cases, for example on level crossings
* This enables gravitystorm#1007 (allow collisions with some symbols)
@matthijsmelissen
Copy link
Collaborator

I have tested this, and I think this can be merged, provided #1010 (road halos) is merged as well.

@matthijsmelissen
Copy link
Collaborator

You could consider allowing collisions for peaks as well.

@matkoniecz
Copy link
Contributor Author

@math1985 There are areas with high peak density giving results even worse than my parking example ( #982 (comment) ). Some people micromapped the slightest hill in their city as a peaks, what would result in peak icons merging and covering anything except labels.

Note that such tagging is OK according to http://wiki.openstreetmap.org/wiki/Tag:natural%3Dpeak

@gravitystorm
Copy link
Owner

Sorry, I don't want to see half-a-symbol peeking out from behind something else, that's really low-quality cartography. If our priority is wrong (e.g. if road labels are more important than gates) then they should be rendered first.

Overlapping stuff is a fudge, just like transparency!

@matthijsmelissen
Copy link
Collaborator

@mkoniecz Could you generated the second example again with #1010 merged into your branch? I would need to see how that looks before I can form an opinion.

@matthijsmelissen
Copy link
Collaborator

I think moving the layers for towers and gates etc. above the text layers would be doable. It would also prevent half-gates from peeking out under other icons - not sure if that's an improvement or not, but at least @gravitystorm seems to think it is.

With that method, I think we would be able to include peaks as well.

@mboeringa
Copy link

Sorry, I don't want to see half-a-symbol peeking out from behind something else, that's really low-quality cartography. If our priority is wrong (e.g. if road labels are more important than gates) then they should be rendered first.

Overlapping stuff is a fudge, just like transparency!

I think most here agree, but I think this was an attempt at a kind of compromise to keep some "gate-mappers" happy and still show gates at zoom levels they probably shouldn't be displayed at...

Maybe it requires an "executive" decision by you all maintaining the style, to no longer render gates at anything but Z18 or 19 (you might be able to get away with Z17 looking at this example), because that is the level of detail these micro-mapped gates are only reasonably viewable without major compromises or problems with collisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants