Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Unit test FormLogin #35

Merged
merged 5 commits into from
Feb 26, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
164 changes: 164 additions & 0 deletions packages/shared/components/FormLogin/FormLogin.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,164 @@
/**
* Copyright 2020 Gravitational, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import React from 'react';
import FormLogin from './FormLogin';
import { render, fireEvent } from 'design/utils/testing';
import theme from '../../../design/src/theme';
import { Auth2faTypeEnum, AuthProviderTypeEnum } from '../../services/enums';
import { TypeEnum as Type } from '../ButtonSso/';

const ssoProvider = [
{ type: AuthProviderTypeEnum.OIDC, url: '', name: Type.GITHUB },
{ type: AuthProviderTypeEnum.OIDC, url: '', name: Type.GOOGLE },
];

test.each`
auth2faType | isProcessing | authProviders | expTexts
${Auth2faTypeEnum.DISABLED} | ${false} | ${ssoProvider} | ${[Type.GITHUB, Type.GOOGLE]}
${Auth2faTypeEnum.DISABLED} | ${false} | ${[]} | ${[]}
${Auth2faTypeEnum.OTP} | ${false} | ${[]} | ${['two factor token', 'download google authenticator']}
${Auth2faTypeEnum.UTF} | ${true} | ${[]} | ${['insert your U2F key and press the button on the key']}
`(
'test render and error states w/ auth2faType: $auth2faType, w/ authProviders: $authProviders',
({ auth2faType, isProcessing, authProviders, expTexts }) => {
const onLogin = jest.fn();
const onLoginWithSso = jest.fn();
const onLoginWithU2f = jest.fn();
const errorColor = theme.colors.error.main;

const { getByText } = render(
<FormLogin
title="titleText"
auth2faType={auth2faType}
authProviders={authProviders}
attempt={{ isFailed: false, isProcessing, message: '' }}
onLogin={onLogin}
onLoginWithSso={onLoginWithSso}
onLoginWithU2f={onLoginWithU2f}
/>
);

// test basics are rendered
expect(getByText('titleText')).toBeInTheDocument();
expect(getByText(/username/i)).toBeInTheDocument();
expect(getByText(/password/i)).toBeInTheDocument();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for these

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revised, i kept one test to see if titleText rendered


// test prop specifics are rendered
expTexts.forEach(text => {
const re = new RegExp(text, 'i');
expect(getByText(re)).toBeInTheDocument();
});

if (isProcessing) {
expect(getByText(/login/i)).toBeDisabled();
return;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is only the case for U2F keys, maybe we should just remove this case from the testing table and treat it separately?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mainly concerned with the return statement, which skips the majority of the test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revised


// test input element validation error states
fireEvent.click(getByText(/login/i));

if (auth2faType == Auth2faTypeEnum.OTP) {
const tokenLabel = getByText(/token is required/i);
expect(tokenLabel).toHaveStyle({ color: errorColor });
expect(tokenLabel.nextElementSibling).toHaveStyle({
'border-color': errorColor,
});
}

let usernameLabel = getByText(/username is required/i);
expect(usernameLabel).toHaveStyle({ color: errorColor });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to test styling of InputField component. It would be enough to verify the presence of the error message

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revised

expect(usernameLabel.nextElementSibling).toHaveStyle({
'border-color': errorColor,
});

const passwordLabel = getByText(/password is required/i);
expect(passwordLabel).toHaveStyle({ color: errorColor });
expect(passwordLabel.nextElementSibling).toHaveStyle({
'border-color': errorColor,
});

// test changing input value removes error state
fireEvent.change(usernameLabel.nextElementSibling, {
target: { value: 'a' },
});
expect(getByText(/username/i)).toHaveStyle({ color: theme.colors.light });

// test deleting input value triggers back error state
fireEvent.change(getByText(/username/i).nextElementSibling, {
target: { value: '' },
});
usernameLabel = getByText(/username is required/i);
expect(usernameLabel).toHaveStyle({ color: errorColor });
expect(usernameLabel.nextElementSibling).toHaveStyle({
'border-color': errorColor,
});
}
);

test.each`
auth2faType | authProviders | testPurpose
${Auth2faTypeEnum.DISABLED} | ${ssoProvider} | ${'onLoginWithSso'}
${Auth2faTypeEnum.DISABLED} | ${[]} | ${'onLogin'}
${Auth2faTypeEnum.OTP} | ${[]} | ${'onLogin'}
${Auth2faTypeEnum.UTF} | ${[]} | ${'onLoginWithU2f'}
`(
'test prop $testPurpose is respected with auth2faType: $auth2faType',
({ auth2faType, authProviders }) => {
const onLogin = jest.fn();
const onLoginWithSso = jest.fn();
const onLoginWithU2f = jest.fn();

const { getByText } = render(
<FormLogin
auth2faType={auth2faType}
authProviders={authProviders}
attempt={{ isFailed: false, isProcessing: false, message: '' }}
onLogin={onLogin}
onLoginWithSso={onLoginWithSso}
onLoginWithU2f={onLoginWithU2f}
/>
);

// fill out form
const usernameInput = getByText(/username/i).nextElementSibling;
fireEvent.change(usernameInput, { target: { value: 'a' } });

const passwordInput = getByText(/password/i).nextElementSibling;
fireEvent.change(passwordInput, { target: { value: 'a' } });

if (auth2faType == Auth2faTypeEnum.OTP) {
const tokenInput = getByText(/two factor token/i).nextElementSibling;
fireEvent.change(tokenInput, { target: { value: 'a' } });
}

// test login clicks calls the correct cb's
if (authProviders.length > 0) {
const re = new RegExp(Type.GITHUB, 'i');
fireEvent.click(getByText(re));
expect(onLoginWithSso).toHaveBeenCalledTimes(1);
}

fireEvent.click(getByText(/login/i));

if (auth2faType == Auth2faTypeEnum.UTF) {
expect(onLoginWithU2f).toHaveBeenCalledTimes(1);
return;
}

expect(onLogin).toHaveBeenCalledTimes(1);
}
);