Unit test FormLogin

[kimlisa]

part of #21

[pierrebeaucamp]

As this is only the case for U2F keys, maybe we should just remove this case from the testing table and treat it separately?

[pierrebeaucamp]

I'm mainly concerned with the return statement, which skips the majority of the test

[kimlisa]

revised

[alex-kovoy]

tables work nicely where input/expected values are easier to understand and they follow 1-3 expect statements (like math functions, validation rules, etc). In this scenario it is another way around, we have a few cases in the table following a lot of logic with many expects.

Instead, we can have a separate test per each test-case: login with username/password only with OTP, with U2F

test('login with username and password only', () => {
  const onLogin = jest.fn();
  const { getByText, getByPlaceholderText } = render(
    <FormLogin
      title="titleText"
      auth2faType={Auth2faTypeEnum.DISABLED}     
      attempt={{ isFailed: false, isProcessing: false, message: '' }}
      onLogin={onLogin}
    />
  );

  fireEvent.change(getByPlaceholderText('User name'), { target: { value: 'username' }, });
  fireEvent.change(getByPlaceholderText('Password'), { target: { value: '123' }, });
  fireEvent.click(getByText('LOGIN'));

  expect(onLogin).toHaveBeenCalledWith('username', '123', '');
});

test('login with OTP', () => {
  ...
})

test('input validation errors', () => {
  const onLogin = jest.fn();
  const { getByText, getByPlaceholderText } = render(
    <FormLogin
      title="titleText"
      auth2faType={Auth2faTypeEnum.OTP}     
      attempt={{ isFailed: false, isProcessing: false, message: '' }}
      onLogin={onLogin}
    />
  );
  
  fireEvent.click(getByText('LOGIN'));

  expect(onLogin).not.toHaveBeenCalled()
  expect('error text....
  expect('error text....
});

[kimlisa]

refactored

[alex-kovoy]

no need for these

[kimlisa]

revised, i kept one test to see if titleText rendered

[alex-kovoy]

no need to test styling of InputField component. It would be enough to verify the presence of the error message

[kimlisa]

revised