This repository was archived by the owner on Feb 8, 2024. It is now read-only.
Update sessionPath value to new endpoint#1486
Merged
Conversation
kimlisa
approved these changes
Jan 4, 2023
Contributor
kimlisa
left a comment
kimlisa
left a comment
There was a problem hiding this comment.
similar name change as backend
|
|
||
| scp: '/v1/webapi/sites/:clusterId/nodes/:serverId/:login/scp?location=:location&filename=:filename', | ||
| renewTokenPath: '/v1/webapi/sessions/renew', | ||
| renewTokenPath: '/v1/webapi/sessions/web/renew', |
Contributor
There was a problem hiding this comment.
Suggested change
| renewTokenPath: '/v1/webapi/sessions/web/renew', | |
| webRenewTokenPath: '/v1/webapi/sessions/web/renew', |
| renewTokenPath: '/v1/webapi/sessions/web/renew', | ||
| resetPasswordTokenPath: '/v1/webapi/users/password/token', | ||
| sessionPath: '/v1/webapi/sessions', | ||
| sessionPath: '/v1/webapi/sessions/web', |
Contributor
There was a problem hiding this comment.
Suggested change
| sessionPath: '/v1/webapi/sessions/web', | |
| webSessionPath: '/v1/webapi/sessions/web', |
hatched
approved these changes
Jan 5, 2023
ibeckermayer
approved these changes
Jan 5, 2023
avatus
added a commit
that referenced
this pull request
Jan 5, 2023
avatus
added a commit
that referenced
this pull request
Jan 5, 2023
This was referenced Jan 5, 2023
avatus
added a commit
that referenced
this pull request
Jan 6, 2023
avatus
added a commit
that referenced
this pull request
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When gravitational/teleport#19593 went in, it removed the deprecated(?) route to
webapi/sessionsin favor ofwebapi/sessions/webbut the frontend was never updated since v5 to change this route. It looks like we were always calling to the same old route instead of the updated one. When the old route was removed, you can no longer login on the web ui.This change allows the login with the web ui again. I've checked around to find other instances and so far haven't found any but I may have missed something. Some sets of eyes and any historical data around this route would be great!
Teleport buddy: gravitational/teleport#19892