Fix initKube: broadcast KubeReady event #9418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallinsky
force-pushed
the
smallinsky/broadcast_kube_ready_state
branch
from
e2d1d0d to
1eac241
Compare
fspmarshall
approved these changes
Dec 15, 2021
r0mant
approved these changes
Dec 15, 2021
There was a problem hiding this comment.
@smallinsky Can you please add test coverage for this as well? We can do it in a follow PR though, so we can merge the fix first.
smallinsky
force-pushed
the
smallinsky/broadcast_kube_ready_state
branch
3 times, most recently
from
c07f825 to
7137e21
Compare
smallinsky
force-pushed
the
smallinsky/broadcast_kube_ready_state
branch
from
e7888a8 to
809a37b
Compare
smallinsky
added a commit
that referenced
this pull request
Mar 7, 2022
smallinsky
added a commit
that referenced
this pull request
Mar 7, 2022
smallinsky
added a commit
that referenced
this pull request
Mar 9, 2022
smallinsky
added a commit
that referenced
this pull request
Mar 9, 2022
zmb3
added a commit
that referenced
this pull request
Jul 22, 2022
When desktop access is enabled, the TeleportReady event will not be emitted until the WindowsDesktopReadyEvent is emitted, and it turns out we have *never* emitted a WindowsDesktopReadyEvent. This is likely due to desktop access being copied from kube access since the very beginning. The same issue was recently fixed for kube access in #9418.
zmb3
added a commit
that referenced
this pull request
Jul 22, 2022
When desktop access is enabled, the TeleportReady event will not be emitted until the WindowsDesktopReadyEvent is emitted, and it turns out we have *never* emitted a WindowsDesktopReadyEvent. This is likely due to desktop access being copied from kube access since the very beginning. The same issue was recently fixed for kube access in #9418.
zmb3
added a commit
that referenced
this pull request
Jul 25, 2022
When desktop access is enabled, the TeleportReady event will not be emitted until the WindowsDesktopReadyEvent is emitted, and it turns out we have *never* emitted a WindowsDesktopReadyEvent. This is likely due to desktop access being copied from kube access since the very beginning. The same issue was recently fixed for kube access in #9418.
zmb3
added a commit
that referenced
this pull request
Jul 25, 2022
Ensure that the WindowsDesktopReady event is emitted When desktop access is enabled, the TeleportReady event will not be emitted until the WindowsDesktopReadyEvent is emitted, and it turns out we have *never* emitted a WindowsDesktopReadyEvent. This is likely due to desktop access being copied from kube access since the very beginning. The same issue was recently fixed for kube access in #9418.
zmb3
added a commit
that referenced
this pull request
Jul 25, 2022
Ensure that the WindowsDesktopReady event is emitted When desktop access is enabled, the TeleportReady event will not be emitted until the WindowsDesktopReadyEvent is emitted, and it turns out we have *never* emitted a WindowsDesktopReadyEvent. This is likely due to desktop access being copied from kube access since the very beginning. The same issue was recently fixed for kube access in #9418.
zmb3
added a commit
that referenced
this pull request
Jul 25, 2022
Ensure that the WindowsDesktopReady event is emitted When desktop access is enabled, the TeleportReady event will not be emitted until the WindowsDesktopReadyEvent is emitted, and it turns out we have *never* emitted a WindowsDesktopReadyEvent. This is likely due to desktop access being copied from kube access since the very beginning. The same issue was recently fixed for kube access in #9418.
zmb3
added a commit
that referenced
this pull request
Jul 25, 2022
When desktop access is enabled, the TeleportReady event will not be emitted until the WindowsDesktopReadyEvent is emitted, and it turns out we have *never* emitted a WindowsDesktopReadyEvent. This is likely due to desktop access being copied from kube access since the very beginning. The same issue was recently fixed for kube access in #9418. Backports #14804
zmb3
added a commit
that referenced
this pull request
Aug 4, 2022
Ensure that the WindowsDesktopReady event is emitted When desktop access is enabled, the TeleportReady event will not be emitted until the WindowsDesktopReadyEvent is emitted, and it turns out we have *never* emitted a WindowsDesktopReadyEvent. This is likely due to desktop access being copied from kube access since the very beginning. The same issue was recently fixed for kube access in #9418.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add missing
KubernetesReadybroadcast event call - fix cert rotation when kube service is enabled.Why:
If the kube service is running in the same process with auth and proxy services the
TeleportReadyEventis never broadcasted because it requires theKubernetesReadyevent to be broadcasted firstteleport/lib/service/service.go
Line 747 in 97c18fa
Some teleport logic like cert rotation
periodicSyncRotationStatetriggers only if teleport is inTeleporReadystate.teleport/lib/service/connect.go
Line 431 in 97c18fa