-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v8] Ensure that the WindowsDesktopReady event is emitted #14859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the WindowsDesktopReady event is emitted When desktop access is enabled, the TeleportReady event will not be emitted until the WindowsDesktopReadyEvent is emitted, and it turns out we have *never* emitted a WindowsDesktopReadyEvent. This is likely due to desktop access being copied from kube access since the very beginning. The same issue was recently fixed for kube access in #9418.
@fspmarshall @r0mant please take a look |
r0mant
approved these changes
Jul 29, 2022
@fspmarshall can I get your +1 on this? |
fspmarshall
approved these changes
Aug 1, 2022
Unlike in v9+, desktop access in v8 will not run without a connection to an LDAP server, so this test won't pass, even though the change is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the WindowsDesktopReady event is emitted
When desktop access is enabled, the TeleportReady event will not
be emitted until the WindowsDesktopReadyEvent is emitted, and it
turns out we have never emitted a WindowsDesktopReadyEvent.
This is likely due to desktop access being copied from kube access
since the very beginning. The same issue was recently fixed for
kube access in #9418.
Backports #14804