Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8] Ensure that the WindowsDesktopReady event is emitted #14859

Merged
merged 10 commits into from
Aug 4, 2022

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Jul 25, 2022

Ensure that the WindowsDesktopReady event is emitted

When desktop access is enabled, the TeleportReady event will not
be emitted until the WindowsDesktopReadyEvent is emitted, and it
turns out we have never emitted a WindowsDesktopReadyEvent.

This is likely due to desktop access being copied from kube access
since the very beginning. The same issue was recently fixed for
kube access in #9418.

Backports #14804

Ensure that the WindowsDesktopReady event is emitted

When desktop access is enabled, the TeleportReady event will not
be emitted until the WindowsDesktopReadyEvent is emitted, and it
turns out we have *never* emitted a WindowsDesktopReadyEvent.

This is likely due to desktop access being copied from kube access
since the very beginning. The same issue was recently fixed for
kube access in #9418.
@zmb3 zmb3 enabled auto-merge (squash) July 29, 2022 22:25
@zmb3
Copy link
Collaborator Author

zmb3 commented Jul 29, 2022

@fspmarshall @r0mant please take a look

@zmb3
Copy link
Collaborator Author

zmb3 commented Aug 1, 2022

@fspmarshall can I get your +1 on this?

@github-actions github-actions bot removed the request for review from russjones August 1, 2022 15:27
zmb3 added 4 commits August 2, 2022 10:31
Unlike in v9+, desktop access in v8 will not run without a connection
to an LDAP server, so this test won't pass, even though the change
is correct.
@zmb3 zmb3 merged commit bb36178 into branch/v8 Aug 4, 2022
@zmb3 zmb3 deleted the zmb3/v8-backport-14804 branch August 4, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants