add value to let you annotate the service account#6586
Closed
timothy-spencer wants to merge 5 commits intogravitational:masterfrom
Closed
add value to let you annotate the service account#6586timothy-spencer wants to merge 5 commits intogravitational:masterfrom
timothy-spencer wants to merge 5 commits intogravitational:masterfrom
Conversation
timothy-spencer
requested review from
klizhentas,
r0mant and
russjones
as code owners
Contributor
|
@timothy-spencer thank you for your PR. We will review and get back to you! Have a great day 👋 |
Contributor
|
@timothy-spencer Thank you for your contribution! @webvictim You're reworking Helm charts in #6344, can you take a look at this and see if these changes make sense in the context of new Helm charts? |
Contributor
|
@timothy-spencer I'll add support for serviceAccount annotations into #6344, as that PR is introducing a whole Edit: added in d3eb086 |
Contributor
Author
|
Supercool. That looks great to me! Thank you! This will make it much easier to integrate with EKS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For similar reasons to #5271, I would like to be able to annotate the serviceaccount.
Let me know if you like this or have suggestions, whatever! Thanks, and have fun!