Adding annotations to the serviceAccount definition #5271
Merged
webvictim merged 8 commits intogravitational:masterfrom Jan 20, 2021
Merged
Adding annotations to the serviceAccount definition #5271webvictim merged 8 commits intogravitational:masterfrom
webvictim merged 8 commits intogravitational:masterfrom
Conversation
…be used on AWS EKS deployments
robcoward
requested review from
awly,
r0mant,
russjones and
webvictim
as code owners
…lability and passing through loadBalancerSourceRanges when service type is LoadBalancer
awly
approved these changes
Jan 15, 2021
Contributor
awly
left a comment
awly
left a comment
There was a problem hiding this comment.
LGTM, let's wait for @webvictim to sign off too
webvictim
approved these changes
Jan 15, 2021
Contributor
webvictim
left a comment
webvictim
left a comment
There was a problem hiding this comment.
LGTM too, thanks for the PR!
Contributor
|
@robcoward One more update from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to allow Teleport to use IRSA for authentication on AWS EKS deployments, the serviceAccount needs to be able to pass an annotation for the IAM role, such as:
This PR allows the annotations to be specified in the helm chart values.yml overrides.
Added the ability to pass
loadBalancerSourceRangesto the service when type: LoadBalancer.Added separate values to use for the auth service when
.Values.config.highAvailability: trueAddresses part of #3656
Also corrects a defect when trying to pass
.Values.service.labels