[v17] Fix flaky test TestChaosUpload#64501
Merged
Joerger merged 1 commit intobranch/v17from Apr 2, 2026
Merged
Conversation
* Significantly speed up TestChaosUpload with a more aggressive scan period. * Add missing close for encrypted upload error. * Don't treat empty uploads as a session error. * Defer close. * Add comment.
Joerger
added
flaky tests
no-changelog
Joerger
changed the title
TestChaosUploadTestChaosUpload
github-actions
bot
added
audit-log
github-actions
bot
requested review from
Tener,
ravicious,
rosstimothy,
tigrato and
zmb3
Tener
requested changes
Mar 11, 2026
Contributor
Tener
left a comment
Tener
left a comment
There was a problem hiding this comment.
Is the "no changelog" accurate? We are applying a fix to lib/events/filesessions/fileasync.go, even though it is subtle. There is a latent chance this will cause trouble and without changelog entry it will be that much harder to track.
Joerger
removed
the
no-changelog
Contributor
Author
|
@Tener Sure thing, added a changelog. @zmb3 @rosstimothy This needs a flaky test skip since the test takes too long. |
Tener
approved these changes
Apr 2, 2026
tigrato
approved these changes
Apr 2, 2026
public-teleport-github-review-bot
bot
removed request for
eriktate,
ravicious,
rosstimothy and
zmb3
Contributor
The flaky test detector is not a required check on release branches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix error handling around empty uploads to ensure upload resources are consistently cleaned up.
Backport #62189 to branch/v17