Merged
Conversation
bb68b45 to
a7dbadd
Compare
a7dbadd to
59ac781
Compare
Tener
approved these changes
Dec 12, 2025
zmb3
reviewed
Dec 12, 2025
tigrato
reviewed
Dec 12, 2025
Contributor
Author
|
@rosstimothy @zmb3 Can you give this a flaky test skip? Looks like it's just timing out, takes just under 6s locally: |
rosstimothy
approved these changes
Dec 17, 2025
Contributor
|
/excludeflake * |
tigrato
approved these changes
Dec 18, 2025
Contributor
rosstimothy
pushed a commit
that referenced
this pull request
Jan 5, 2026
* Significantly speed up TestChaosUpload with a more aggressive scan period. * Add missing close for encrypted upload error. * Don't treat empty uploads as a session error. * Defer close. * Add comment.
21KennethTran
pushed a commit
that referenced
this pull request
Jan 6, 2026
* Significantly speed up TestChaosUpload with a more aggressive scan period. * Add missing close for encrypted upload error. * Don't treat empty uploads as a session error. * Defer close. * Add comment.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 7, 2026
* Significantly speed up TestChaosUpload with a more aggressive scan period. * Add missing close for encrypted upload error. * Don't treat empty uploads as a session error. * Defer close. * Add comment. Co-authored-by: Brian Joerger <bjoerger@goteleport.com>
ravicious
reviewed
Feb 5, 2026
Member
There was a problem hiding this comment.
Is it feasible to backport these changes to v17? I just got a hit on v17. I tried backporting this PR myself, but it doesn't backport cleanly.
Joerger
added a commit
that referenced
this pull request
Mar 11, 2026
* Significantly speed up TestChaosUpload with a more aggressive scan period. * Add missing close for encrypted upload error. * Don't treat empty uploads as a session error. * Defer close. * Add comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change:
sessionErrorinuploadEncrypted, mirroring the defaultuploadmethod..errorfile if relevant. However, this can be handled in a follow up PR if the legacy behavior is deemed undesirable rather than blocking this high priority flaky test fix.uploadEncryptedhits an unexpected error. This flake appeared once ^ was fixed.Closes #33099