[Connect] Provide empty resourceAccessId arr for Access Req dryrun#63789
Merged
[Connect] Provide empty resourceAccessId arr for Access Req dryrun#63789
Conversation
- Provide empty resourceAccessId arr rather than `undefined` for Access Req DryRun in Connect, as follow-up Resource Constraint-related PRs are delayed.
kiosion
added
the
no-changelog
kiosion
added a commit
that referenced
this pull request
Feb 13, 2026
(#63789) * fix: Provide empty resourceAccessId arr for Access Req dryrun
ravicious
approved these changes
Mar 6, 2026
gzdunek
approved these changes
Mar 6, 2026
public-teleport-github-review-bot
Bot
removed request for
r0mant,
rudream,
ryanclark and
smallinsky
Contributor
nixpig
pushed a commit
that referenced
this pull request
Mar 11, 2026
- Provide empty resourceAccessId arr rather than `undefined` for Access Req DryRun in Connect, as follow-up Resource Constraint-related PRs are delayed.
kiosion
added a commit
that referenced
this pull request
Mar 24, 2026
(#63789) * fix: Provide empty resourceAccessId arr for Access Req dryrun
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 24, 2026
* Access Requests: Add Resource-Scoped Constraints (#60123) * feat: Extend `AWSRole` struct w/ `RequiresRequest` - Differentiate between already-granted vs. requestable AWSRoles when including requestable resources in `clusterUnifiedResourcesGet` req * feat: Implement Resource Constraints support for Proxy, Auth * fixup: Fix tests * test: Add tests for resourceaccessid-related helpers * fixup: Address code review feedback * test: Update identity/events tests for new `ResourceAccessID` fields * fixup: Expand/improve godocs/comments for sentinel ResourceID handling * fixup: Address code review feedback * feat: Conv ResourceID->ResourceAccessID at cert decoding - Convert ResourceIDs present on certs to ResourceAccessIDs at decoding time, rather than at each callsite. Update tests/usages of tlsca/sshca Identities to reflect this. * Access Requests: Web UI handling for Resource-Scoped Constraints (#62152) * feat: Implement Resource Constraints for Web * fixup: Address code review feedback * test: Add stories for Resource Constraint RequestCheckout changes * fixup: Address code review feedback * [Connect] Update types for ResourceConstraints support (#63492) * types: Update protos for Teleterm support of ResourceConstraints * fixup: Resolve test/story type errors from proto field changes * [Access Requests] Show constrained resources in tsh/tctl (#63619) * feat: Show constrained resources in tsh/tctl - Part 1 of supporting Resource Constraints in tsh/tctl. Show constraints alongside relevant ResourceIDs when listing/showing an Access Request in tsh/tctl. * fixup: Address code review feedback * [Connect] Provide empty resourceAccessId arr for Access Req dryrun (#63789) * fix: Provide empty resourceAccessId arr for Access Req dryrun
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Remaining Resource Constraint-related PRs are postponed to batch together with Long-Term Access Request support for Connect. In the meantime, breaking out this fix to provide an empty arr for resourceAccessIds rather than
undefined.