[Connect] Update types for ResourceConstraints support#63492
Merged
Conversation
kiosion
added
no-changelog
ravicious
approved these changes
Feb 4, 2026
Member
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
Looks fine, though I wonder if it wouldn't be able to batch this with the actual code changes. This way if you find yourself needing to adjust the protos a little bit, you won't have to deal with the buf lint and the way it enforces no breaking changes.
| package teleport.lib.teleterm.v1; | ||
|
|
||
| import "google/protobuf/timestamp.proto"; | ||
| import "teleport/legacy/types/resources.proto"; |
Member
There was a problem hiding this comment.
generate_dependencies keeps paying dividends (#59817). 🙌 Without it, the path to this proto file would have to be added to buf-ts.gen.yaml.
Contributor
Author
I considered that but figured it'd be easier to review in pieces, and I can't see requiring any changes to these types; they're just adding fields already implemented for the Web UI side of protos. |
gzdunek
approved these changes
Feb 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
kiosion
added a commit
that referenced
this pull request
Feb 10, 2026
* types: Update protos for Teleterm support of ResourceConstraints * fixup: Resolve test/story type errors from proto field changes
21 tasks
44 tasks
kiosion
added a commit
that referenced
this pull request
Mar 24, 2026
* types: Update protos for Teleterm support of ResourceConstraints * fixup: Resolve test/story type errors from proto field changes
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 24, 2026
* Access Requests: Add Resource-Scoped Constraints (#60123) * feat: Extend `AWSRole` struct w/ `RequiresRequest` - Differentiate between already-granted vs. requestable AWSRoles when including requestable resources in `clusterUnifiedResourcesGet` req * feat: Implement Resource Constraints support for Proxy, Auth * fixup: Fix tests * test: Add tests for resourceaccessid-related helpers * fixup: Address code review feedback * test: Update identity/events tests for new `ResourceAccessID` fields * fixup: Expand/improve godocs/comments for sentinel ResourceID handling * fixup: Address code review feedback * feat: Conv ResourceID->ResourceAccessID at cert decoding - Convert ResourceIDs present on certs to ResourceAccessIDs at decoding time, rather than at each callsite. Update tests/usages of tlsca/sshca Identities to reflect this. * Access Requests: Web UI handling for Resource-Scoped Constraints (#62152) * feat: Implement Resource Constraints for Web * fixup: Address code review feedback * test: Add stories for Resource Constraint RequestCheckout changes * fixup: Address code review feedback * [Connect] Update types for ResourceConstraints support (#63492) * types: Update protos for Teleterm support of ResourceConstraints * fixup: Resolve test/story type errors from proto field changes * [Access Requests] Show constrained resources in tsh/tctl (#63619) * feat: Show constrained resources in tsh/tctl - Part 1 of supporting Resource Constraints in tsh/tctl. Show constraints alongside relevant ResourceIDs when listing/showing an Access Request in tsh/tctl. * fixup: Address code review feedback * [Connect] Provide empty resourceAccessId arr for Access Req dryrun (#63789) * fix: Provide empty resourceAccessId arr for Access Req dryrun
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Update protos/types to enable ResourceConstraint support in Access Requests.
Required for #63472.