Merged
Conversation
Adds the MNT_DETACH flag to the cgroups unmount call to workaround issues stemming from a behavior chagne in Go 1.25 to support automatically setting GOMAXPROCS. In doing so the Go runtime interacts with cgroups to determine what limits should be applied which interferes with our ability to clean up. Fixes #58879.
* chore: Bump golangci-lint to v2.7.2 * Update e/ reference * Fix require.IsType issues * Reverse require.Equal * Simplify testWebsockets * Fix TestCreateResources * Remove trace.Unwrap
wethreetrees
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
Contributor
|
Amplify deployment status
|
wethreetrees
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
wethreetrees
requested review from
camscale,
doggydogworld,
fheinecke,
hugoShaka,
r0mant,
rosstimothy,
russjones,
strideynet,
tigrato and
zmb3
as code owners
github-actions
bot
added
audit-log
github-actions
bot
requested review from
bernardjkim,
espadolini and
klizhentas
This was referenced Feb 6, 2026
tigrato
reviewed
Feb 6, 2026
Contributor
tigrato
left a comment
tigrato
left a comment
There was a problem hiding this comment.
is there a reason to upgrade go from 1.24?
We try to avoid updating go unless it goes EOL
Contributor
|
Go 1.24 will be EOL this month when Go 1.26 is released. We're trying to get ahead of that this time around. |
rosstimothy
approved these changes
Feb 6, 2026
tigrato
approved these changes
Feb 6, 2026
public-teleport-github-review-bot
bot
removed request for
bernardjkim,
espadolini and
klizhentas
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
* chore: Bump Go to 1.25.7 * Lazily unmount cgroups Adds the MNT_DETACH flag to the cgroups unmount call to workaround issues stemming from a behavior chagne in Go 1.25 to support automatically setting GOMAXPROCS. In doing so the Go runtime interacts with cgroups to determine what limits should be applied which interferes with our ability to clean up. Fixes #58879. * chore: Bump golangci-lint to v2.7.2 (#62066) * chore: Bump golangci-lint to v2.7.2 * Update e/ reference * Fix require.IsType issues * Reverse require.Equal * Simplify testWebsockets * Fix TestCreateResources * Remove trace.Unwrap * chore: tidy modules --------- Co-authored-by: Alan Parra <12500300+codingllama@users.noreply.github.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Go to the latest patch.
Note: Including some changes from ad08e94b re: cgroup unmount. Pulled these in from #58875.
Also had to update
golangci-lint(v2.1.5was built withgo1.24) leading to linter issues. Pulled in changes from #62066 to resolve these new issues. I chosegolangci-lint v2.7.2since that is the latest version we have upgraded to inmaster.teleport/build.assets/versions.mk
Line 6 in 84ba745
Changelog: Updated Go to 1.25.7