Skip to content

chore: Bump golangci-lint to v2.7.2#62066

Merged
codingllama merged 7 commits intomasterfrom
codingllama/bump-golangcilint
Dec 9, 2025
Merged

chore: Bump golangci-lint to v2.7.2#62066
codingllama merged 7 commits intomasterfrom
codingllama/bump-golangcilint

Conversation

@codingllama
Copy link
Copy Markdown
Contributor

@codingllama codingllama commented Dec 8, 2025

@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Dec 8, 2025
@codingllama
Copy link
Copy Markdown
Contributor Author

codingllama commented Dec 8, 2025

It was still running locally when I opened, but this will need code fixes. I'll move to draft in the meantime.

@codingllama codingllama marked this pull request as draft December 8, 2025 17:22
@codingllama
Copy link
Copy Markdown
Contributor Author

codingllama commented Dec 8, 2025 •
edited
Loading

I'm having a hard time with ./integration/appaccess tests locally, but nevertheless I think it should all be good now.

@codingllama codingllama marked this pull request as ready for review December 8, 2025 18:16
@github-actions github-actions bot added audit-log Issues related to Teleports Audit Log database-access Database access related issues and PRs tctl tctl - Teleport admin tool labels Dec 8, 2025
tigrato
tigrato reviewed Dec 9, 2025
View reviewed changes
Comment thread lib/events/test/streamsuite.go
Comment thread lib/services/license_test.go
input string
expected types.License
err error
err any
Copy link
Copy Markdown
Contributor

@tigrato tigrato Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Copy Markdown
Contributor Author

@codingllama codingllama Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an error to call errors.As with an error type. The linter shouts (and it's wrong).

Comment thread lib/services/map_test.go
Comment thread lib/services/role_test.go Outdated
@codingllama
Copy link
Copy Markdown
Contributor Author

codingllama commented Dec 9, 2025

PTAL.

@codingllama codingllama added this pull request to the merge queue Dec 9, 2025
Merged via the queue into master with commit 2740ad6 Dec 9, 2025
44 checks passed
@codingllama codingllama deleted the codingllama/bump-golangcilint branch December 9, 2025 18:26
21KennethTran pushed a commit that referenced this pull request Jan 6, 2026
@codingllama @21KennethTran
chore: Bump golangci-lint to v2.7.2 (#62066)
0b918d3 
* chore: Bump golangci-lint to v2.7.2

* Update e/ reference

* Fix require.IsType issues

* Reverse require.Equal

* Simplify testWebsockets

* Fix TestCreateResources

* Remove trace.Unwrap
wethreetrees pushed a commit that referenced this pull request Feb 5, 2026
@codingllama @wethreetrees
chore: Bump golangci-lint to v2.7.2 (#62066)
31cf85f 
* chore: Bump golangci-lint to v2.7.2

* Update e/ reference

* Fix require.IsType issues

* Reverse require.Equal

* Simplify testWebsockets

* Fix TestCreateResources

* Remove trace.Unwrap
@wethreetrees wethreetrees mentioned this pull request Feb 5, 2026
Merged
wethreetrees pushed a commit that referenced this pull request Feb 5, 2026
@codingllama @wethreetrees
chore: Bump golangci-lint to v2.7.2 (#62066)
253c511 
* chore: Bump golangci-lint to v2.7.2

* Update e/ reference

* Fix require.IsType issues

* Reverse require.Equal

* Simplify testWebsockets

* Fix TestCreateResources

* Remove trace.Unwrap
@wethreetrees wethreetrees mentioned this pull request Feb 5, 2026
Merged
wethreetrees pushed a commit that referenced this pull request Feb 5, 2026
@codingllama @wethreetrees
chore: Bump golangci-lint to v2.7.2 (#62066)
c19f626 
* chore: Bump golangci-lint to v2.7.2

* Update e/ reference

* Fix require.IsType issues

* Reverse require.Equal

* Simplify testWebsockets

* Fix TestCreateResources

* Remove trace.Unwrap
github-merge-queue bot pushed a commit that referenced this pull request Feb 6, 2026
@wethreetrees @codingllama
[v17] Bump Go to 1.25.7 (#63561)
1768835 
* chore: Bump Go to 1.25.7

* Lazily unmount cgroups
Adds the MNT_DETACH flag to the cgroups unmount call to workaround
issues stemming from a behavior chagne in Go 1.25 to support
automatically setting GOMAXPROCS. In doing so the Go runtime
interacts with cgroups to determine what limits should be applied
which interferes with our ability to clean up.

Fixes #58879.

* chore: Bump golangci-lint to v2.7.2 (#62066)

* chore: Bump golangci-lint to v2.7.2

* Update e/ reference

* Fix require.IsType issues

* Reverse require.Equal

* Simplify testWebsockets

* Fix TestCreateResources

* Remove trace.Unwrap

* chore: tidy modules

---------

Co-authored-by: Alan Parra <12500300+codingllama@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Feb 6, 2026
@wethreetrees @codingllama
[v18] Bump Go to 1.25.7 (#63539)
75f211c 
* chore: Bump Go to 1.25.7

* Fix synctest bug with waitgroups
```
=== Failed
=== FAIL: lib/srv/discovery TestDiscoveryServerEKS (unknown)
fatal error: sync: WaitGroup.Add called from multiple synctest bubbles
```

The failure stems from a bug in Go 1.25 and is a result of loading
aws configs which internally use a sync.WaitGroup. This can be worked
around in the short term by mocking out the aws.Config since the test
is configured to use a mock eks client anyway. Other tests may still
run into this issue until Go 1.25.2 - though our relatively small number
of synctest usage at this point may limit our exposure to said bug.

* Lazily unmount cgroups
Adds the MNT_DETACH flag to the cgroups unmount call to workaround
issues stemming from a behavior chagne in Go 1.25 to support
automatically setting GOMAXPROCS. In doing so the Go runtime
interacts with cgroups to determine what limits should be applied
which interferes with our ability to clean up.

Fixes #58879.

* chore: Bump golangci-lint to v2.7.2 (#62066)

* chore: Bump golangci-lint to v2.7.2

* Update e/ reference

* Fix require.IsType issues

* Reverse require.Equal

* Simplify testWebsockets

* Fix TestCreateResources

* Remove trace.Unwrap

---------

Co-authored-by: Alan Parra <12500300+codingllama@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Feb 6, 2026
@wethreetrees @codingllama
[v17] Bump Go to 1.25.7 (#63561)
d499c37 
* chore: Bump Go to 1.25.7

* Lazily unmount cgroups
Adds the MNT_DETACH flag to the cgroups unmount call to workaround
issues stemming from a behavior chagne in Go 1.25 to support
automatically setting GOMAXPROCS. In doing so the Go runtime
interacts with cgroups to determine what limits should be applied
which interferes with our ability to clean up.

Fixes #58879.

* chore: Bump golangci-lint to v2.7.2 (#62066)

* chore: Bump golangci-lint to v2.7.2

* Update e/ reference

* Fix require.IsType issues

* Reverse require.Equal

* Simplify testWebsockets

* Fix TestCreateResources

* Remove trace.Unwrap

* chore: tidy modules

---------

Co-authored-by: Alan Parra <12500300+codingllama@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tigrato tigrato tigrato approved these changes

+1 more reviewer

@vapopov vapopov vapopov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

audit-log Issues related to Teleports Audit Log database-access Database access related issues and PRs no-changelog Indicates that a PR does not require a changelog entry size/sm tctl tctl - Teleport admin tool

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@codingllama @vapopov @tigrato