Fix backwards compatibility with Proxy Recording mode fixes#62213
Merged
Fix backwards compatibility with Proxy Recording mode fixes#62213
Conversation
rosstimothy
reviewed
Dec 12, 2025
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
Is this something we can cover in a test?
Contributor
Author
Not easily since it's a backwards compatibility bug. I'd need to create a server mock to act like an old node and find a way to isolate the code in the forwarding server for unit testing, and I'm not sure exactly what that would look like. |
rosstimothy
approved these changes
Dec 12, 2025
gzdunek
approved these changes
Dec 15, 2025
Joerger
added
the
no-changelog
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
21KennethTran
pushed a commit
that referenced
this pull request
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a backwards compatibility issues in #59850 where an old node would fail to respond to the new
session-id-query-v2@goteleport.comquery and the up to date proxy would treat it as a fatal error for the session:Manual Tests
Last run: 1aa58e9
Backwards compatibility: