[v17] Fix data race in kube proxy watcher tests#62206
Merged
tigrato merged 1 commit intobranch/v17from Dec 18, 2025
Merged
Conversation
This fixes a data race in the kube proxy watcher tests where the AuthClient field of mockAuthClient was being accessed concurrently without synchronization. The issue was introduced in #61642 where the AuthClient was being set after the test context setup, creating a race condition between the server initialization and the test setup. This commit resolves the race by using the WrapAuthClient hook in TestConfig to properly inject the mock client during setup, ensuring the AuthClient is set before any concurrent access can occur. Fixes #62166 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
added
the
no-changelog
rosstimothy
approved these changes
Dec 12, 2025
marcoandredinis
approved these changes
Dec 15, 2025
public-teleport-github-review-bot
bot
removed the request for review
from zmb3
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #62167 to branch/v17