Fix kube servers not deleting when dynamic kube clusters are deleted#61642
Merged
Fix kube servers not deleting when dynamic kube clusters are deleted#61642
Conversation
rosstimothy
approved these changes
Nov 21, 2025
danielashare
approved these changes
Nov 24, 2025
public-teleport-github-review-bot
bot
removed the request for review
from nklaassen
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
atburke
added a commit
that referenced
this pull request
Nov 24, 2025
tigrato
added a commit
that referenced
this pull request
Dec 11, 2025
This fixes a data race in the kube proxy watcher tests where the AuthClient field of mockAuthClient was being accessed concurrently without synchronization. The issue was introduced in #61642 where the AuthClient was being set after the test context setup, creating a race condition between the server initialization and the test setup. This commit resolves the race by using the WrapAuthClient hook in TestConfig to properly inject the mock client during setup, ensuring the AuthClient is set before any concurrent access can occur. Fixes #62166 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
added a commit
that referenced
this pull request
Dec 12, 2025
This fixes a data race in the kube proxy watcher tests where the AuthClient field of mockAuthClient was being accessed concurrently without synchronization. The issue was introduced in #61642 where the AuthClient was being set after the test context setup, creating a race condition between the server initialization and the test setup. This commit resolves the race by using the WrapAuthClient hook in TestConfig to properly inject the mock client during setup, ensuring the AuthClient is set before any concurrent access can occur. Fixes #62166 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
This fixes a data race in the kube proxy watcher tests where the AuthClient field of mockAuthClient was being accessed concurrently without synchronization. The issue was introduced in #61642 where the AuthClient was being set after the test context setup, creating a race condition between the server initialization and the test setup. This commit resolves the race by using the WrapAuthClient hook in TestConfig to properly inject the mock client during setup, ensuring the AuthClient is set before any concurrent access can occur. Fixes #62166 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
backport-bot-workflows bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
This fixes a data race in the kube proxy watcher tests where the AuthClient field of mockAuthClient was being accessed concurrently without synchronization. The issue was introduced in #61642 where the AuthClient was being set after the test context setup, creating a race condition between the server initialization and the test setup. This commit resolves the race by using the WrapAuthClient hook in TestConfig to properly inject the mock client during setup, ensuring the AuthClient is set before any concurrent access can occur. Fixes #62166 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
added a commit
that referenced
this pull request
Dec 12, 2025
This fixes a data race in the kube proxy watcher tests where the AuthClient field of mockAuthClient was being accessed concurrently without synchronization. The issue was introduced in #61642 where the AuthClient was being set after the test context setup, creating a race condition between the server initialization and the test setup. This commit resolves the race by using the WrapAuthClient hook in TestConfig to properly inject the mock client during setup, ensuring the AuthClient is set before any concurrent access can occur. Fixes #62166 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 12, 2025
This fixes a data race in the kube proxy watcher tests where the AuthClient field of mockAuthClient was being accessed concurrently without synchronization. The issue was introduced in #61642 where the AuthClient was being set after the test context setup, creating a race condition between the server initialization and the test setup. This commit resolves the race by using the WrapAuthClient hook in TestConfig to properly inject the mock client during setup, ensuring the AuthClient is set before any concurrent access can occur. Fixes #62166 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2025
This fixes a data race in the kube proxy watcher tests where the AuthClient field of mockAuthClient was being accessed concurrently without synchronization. The issue was introduced in #61642 where the AuthClient was being set after the test context setup, creating a race condition between the server initialization and the test setup. This commit resolves the race by using the WrapAuthClient hook in TestConfig to properly inject the mock client during setup, ensuring the AuthClient is set before any concurrent access can occur. Fixes #62166 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
21KennethTran
pushed a commit
that referenced
this pull request
Jan 6, 2026
This fixes a data race in the kube proxy watcher tests where the AuthClient field of mockAuthClient was being accessed concurrently without synchronization. The issue was introduced in #61642 where the AuthClient was being set after the test context setup, creating a race condition between the server initialization and the test setup. This commit resolves the race by using the WrapAuthClient hook in TestConfig to properly inject the mock client during setup, ensuring the AuthClient is set before any concurrent access can occur. Fixes #62166 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a bug where deleting a dynamic
kube_clusterresource would not delete the associatedkube_serverresource.Fixes #52966.
Changelog: Fixed
tsh kube lsshowing deleted clustersTest Plan
kube_clusterresource and check that it appears withtsh kube ls. Delete the resource and check that it no longer appears withtsh kube ls.