fix: sanitize URL when fetching azure attested data intermediate cert#62158
Merged
fix: sanitize URL when fetching azure attested data intermediate cert#62158
Conversation
rob-picard-teleport
approved these changes
Dec 12, 2025
okraport
approved these changes
Dec 15, 2025
rosstimothy
approved these changes
Dec 19, 2025
public-teleport-github-review-bot
bot
removed the request for review
from eriktate
Contributor
|
@nklaassen See the table below for backport results.
|
This was referenced Dec 19, 2025
21KennethTran
pushed a commit
that referenced
this pull request
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/gravitational/teleport-private/issues/2226
The bug is best described in the linked issue. To summarize, when fetching the intermediate certificate for an Azure VM attested data signature, the intermediate cert URL is taken from the yet-unverified attested data signing cert and not validated before making an HTTP request to that URL, causing a potential SSRF vulnerability.
Auth only fetches the intermediate CA cert over the network when nodes join via the legacy join service. The new azure join method (added in #61129) avoids this by having the joining client include the intermediate cert in the join request.
The fix here maintains compatibility with older agents joining via the legacy join service. Before fetching the intermediate CA, the URL is sanitized to exactly match
http://www.microsoft.com/pkiops/certs/<cert-name>.crt. This may break if Microsoft ever changes this URL format, but hopefully everything will be using the new join service by then and it won't matter.Manual Test Plan
changelog: Fixed a potential SSRF vulnerability in the Azure join method implementation