Skip to content

Azure method support in new join service#61129

Merged
nklaassen merged 3 commits intomasterfrom
nklaassen/azure
Dec 10, 2025
Merged

Azure method support in new join service#61129
nklaassen merged 3 commits intomasterfrom
nklaassen/azure

Conversation

@nklaassen
Copy link
Copy Markdown
Contributor

Part of RFD 27e

This PR adds support for the Azure join method to the new join service and client. Both the new and legacy gRPC servers are updated to use common logic that verifies the request.

Depends on #61128

Manual Test Plan:

  • Azure VM can join via new join service
  • Join attempt denied with subscription mismatch
  • Join attempt denied with resource group mismatch
  • Older agent version can join via legacy join service

@nklaassen nklaassen requested a review from atburke November 7, 2025 01:31
@nklaassen nklaassen added backport-required no-changelog Indicates that a PR does not require a changelog entry labels Nov 7, 2025
Comment thread lib/join/server_azure.go Outdated
@nklaassen nklaassen force-pushed the nklaassen/azure-messages branch from b962ec5 to a43fea9 Compare November 18, 2025 01:32
@nklaassen nklaassen force-pushed the nklaassen/azure-messages branch from a43fea9 to 88e3943 Compare November 20, 2025 01:23
Base automatically changed from nklaassen/azure-messages to master November 26, 2025 19:48
@nklaassen nklaassen enabled auto-merge November 26, 2025 22:54
@nklaassen
Copy link
Copy Markdown
Contributor Author

friendly ping @eriktate this needs a g1 reviewer

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from eriktate December 9, 2025 18:18
@nklaassen nklaassen added this pull request to the merge queue Dec 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2025
@nklaassen nklaassen added this pull request to the merge queue Dec 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2025
@nklaassen nklaassen added this pull request to the merge queue Dec 10, 2025
Merged via the queue into master with commit 932738b Dec 10, 2025
43 of 44 checks passed
@nklaassen nklaassen deleted the nklaassen/azure branch December 10, 2025 19:01
nklaassen added a commit that referenced this pull request Dec 10, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 12, 2025
* [v18] azure join message types

Backport #61128 to branch/v18

* [v18] Azure method support in new join service

Backport #61129 to branch/v18
github-merge-queue bot pushed a commit that referenced this pull request Dec 16, 2025
* [v18] azure join message types

Backport #61128 to branch/v18

* [v18] Azure method support in new join service

Backport #61129 to branch/v18
21KennethTran pushed a commit that referenced this pull request Jan 6, 2026
* Azure method support in new join service

* fix comment typo

* have client send intermediate CA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-required no-changelog Indicates that a PR does not require a changelog entry size/md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants