Do not request resources in teleport-cluster config hooks#61856
Do not request resources in teleport-cluster config hooks#61856
Conversation
|
Looks like there's a failing test to remove too:
|
Config check hooks don't run a full Teleport, they are only validate that the config file is valid. Applying resoucre requests is not useful and can block the rollout in smaller clusters. Changelog: Prevented stuck `teleport-cluster` Helm chart rollouts in smaller clusters. Removed resource requests from configuration check hooks.
a192c35 to
f0c42f1
Compare
|
@hugoShaka See the table below for backport results.
|
Config check hooks don't run a full Teleport, they are only validate that the config file is valid. Applying resoucre requests is not useful and can block the rollout in smaller clusters. Changelog: Prevented stuck `teleport-cluster` Helm chart rollouts in smaller clusters. Removed resource requests from configuration check hooks.
|
@hugoShaka For clusters that have policies that require resources always be set, this will prevent deployments from working. We'll definitely want to make this change be an opt-out behavior rather than off for everywhere. See also: #62597 |
|
Thank you, I did not think of such compliance tools. I can revert the change in v17 but I don't think we should bring the old resource behaviour back, requesting 4cpu and 16GiB of memory to run a config linter is absurd and breaks on small clusters. What I can do is:
|
|
Yes, a separate job resource setting would be great! I think 100MiB might be too small for a default though. I did a quick test and saw the maximum RSS for |
Config check hooks don't run a full Teleport, they are only validate that the config file is valid. Applying resoucre requests is not useful and can block the rollout in smaller clusters.
This is a papercut I faced when doing a large Teleport deployment in resource-constrainted AKS clusters.
Changelog: Prevented stuck
teleport-clusterHelm chart rollouts in small Kubernetes clusters. Removed resource requests from configuration check hooks.