Skip to content

[v18] Generate an Access Monitoring event reference#61746

Merged
ptgott merged 1 commit intobranch/v18from
paul.gottschling/61632-bp-v18
Nov 24, 2025
Merged

[v18] Generate an Access Monitoring event reference#61746
ptgott merged 1 commit intobranch/v18from
paul.gottschling/61632-bp-v18

Conversation

@ptgott
Copy link
Copy Markdown
Contributor

@ptgott ptgott commented Nov 24, 2025

Backports #61632

  • Generate an Access Monitoring event reference

Closes #60074

Use the getters we declared to access protobuf-generated event structs in order to create Athena views for Access Monitoring events, populating a template with the event structs and including examples of tctl audit query exec queries.

Add Make targets to generate the page and check that it was generated. Add a step to the Lint (Proto) job to check that this was generated.

  • Clean up the event schema reference generator
  • Remove unnecessary line breaks.
  • Move teleport requirement into the main require block.
  • Embed the template.
  • Accommodate characters that exceed one byte in prepareDescription.
  • Use a no-allocation alternative to strings.Join in colNameList.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 24, 2025

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
paul.gottschling/61632-bp-v18 20abebb 2 ✅SUCCEED paul-gottschling-61632-bp-v18 2025-11-24 18:58:10

@socket-security
Copy link
Copy Markdown

socket-security bot commented Nov 24, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedgolang/​google.golang.org/​protobuf@​v1.36.1075100100100100

View full report

@ptgott ptgott marked this pull request as ready for review November 24, 2025 18:39
@public-teleport-github-review-bot
Copy link
Copy Markdown

@ptgott - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes.

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from benarent November 24, 2025 18:48
@ptgott ptgott added the no-changelog Indicates that a PR does not require a changelog entry label Nov 24, 2025
@ptgott ptgott enabled auto-merge November 24, 2025 18:50
Backports #61632

* Generate an Access Monitoring event reference

Closes #60074

Use the getters we declared to access protobuf-generated event structs
in order to create Athena views for Access Monitoring events, populating
a template with the event structs and including examples of `tctl audit
query exec` queries.

Add Make targets to generate the page and check that it was generated.
Add a step to the `Lint (Proto)` job to check that this was generated.

* Clean up the event schema reference generator

- Remove unnecessary line breaks.
- Move `teleport` requirement into the main `require` block.
- Embed the template.
- Accommodate characters that exceed one byte in `prepareDescription`.
- Use a no-allocation alternative to strings.Join in `colNameList`.
@ptgott ptgott force-pushed the paul.gottschling/61632-bp-v18 branch from e10f534 to 20abebb Compare November 24, 2025 18:50
@ptgott ptgott added this pull request to the merge queue Nov 24, 2025
Merged via the queue into branch/v18 with commit 032500b Nov 24, 2025
42 checks passed
@ptgott ptgott deleted the paul.gottschling/61632-bp-v18 branch November 24, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport documentation no-changelog Indicates that a PR does not require a changelog entry size/xl

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants