Generate an Access Monitoring event reference#61632
Merged
Conversation
ptgott
had a problem deploying
to
docs-amplify
GitHub Actions
Failure
Contributor
|
Amplify deployment status
|
ptgott
force-pushed
the
paul.gottschling/60074-athena
branch
from
25c4e91 to
017ae55
Compare
ptgott
force-pushed
the
paul.gottschling/60074-athena
branch
from
017ae55 to
22dd4d0
Compare
ptgott
force-pushed
the
paul.gottschling/60074-athena
branch
from
22dd4d0 to
8a4ebc7
Compare
Contributor
Author
|
Reviewer note: We need to find a better place for the generator. |
ptgott
force-pushed
the
paul.gottschling/60074-athena
branch
from
8a4ebc7 to
a7d190c
Compare
benarent
reviewed
Nov 21, 2025
docs/pages/reference/access-controls/access-monitoring-events.mdx
Outdated
Show resolved
Hide resolved
ptgott
had a problem deploying
to
docs-amplify
GitHub Actions
Failure
ptgott
force-pushed
the
paul.gottschling/60074-athena
branch
from
1600cac to
8c27f45
Compare
ptgott
had a problem deploying
to
docs-amplify
GitHub Actions
Failure
ptgott
force-pushed
the
paul.gottschling/60074-athena
branch
from
8c27f45 to
fff4e1f
Compare
ptgott
force-pushed
the
paul.gottschling/60074-athena
branch
from
fff4e1f to
afb249e
Compare
ptgott
force-pushed
the
paul.gottschling/60074-athena
branch
from
afb249e to
b625ee0
Compare
ptgott
requested review from
camscale,
doggydogworld,
fheinecke,
klizhentas,
r0mant,
rosstimothy,
russjones and
zmb3
as code owners
ptgott
added
the
no-changelog
camscale
approved these changes
Nov 24, 2025
public-teleport-github-review-bot
bot
removed request for
aadc-dev,
mmcallister and
ryanclark
Closes #60074 Use the getters we declared to access protobuf-generated event structs in order to create Athena views for Access Monitoring events, populating a template with the event structs and including examples of `tctl audit query exec` queries. Add Make targets to generate the page and check that it was generated. Add a step to the `Lint (Proto)` job to check that this was generated.
- Remove unnecessary line breaks. - Move `teleport` requirement into the main `require` block. - Embed the template. - Accommodate characters that exceed one byte in `prepareDescription`. - Use a no-allocation alternative to strings.Join in `colNameList`.
ptgott
force-pushed
the
paul.gottschling/60074-athena
branch
from
b625ee0 to
9db5af7
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ptgott
added a commit
that referenced
this pull request
Nov 24, 2025
Backports #61632 * Generate an Access Monitoring event reference Closes #60074 Use the getters we declared to access protobuf-generated event structs in order to create Athena views for Access Monitoring events, populating a template with the event structs and including examples of `tctl audit query exec` queries. Add Make targets to generate the page and check that it was generated. Add a step to the `Lint (Proto)` job to check that this was generated. * Clean up the event schema reference generator - Remove unnecessary line breaks. - Move `teleport` requirement into the main `require` block. - Embed the template. - Accommodate characters that exceed one byte in `prepareDescription`. - Use a no-allocation alternative to strings.Join in `colNameList`.
ptgott
added a commit
that referenced
this pull request
Nov 24, 2025
Backports #61632 * Generate an Access Monitoring event reference Closes #60074 Use the getters we declared to access protobuf-generated event structs in order to create Athena views for Access Monitoring events, populating a template with the event structs and including examples of `tctl audit query exec` queries. Add Make targets to generate the page and check that it was generated. Add a step to the `Lint (Proto)` job to check that this was generated. * Clean up the event schema reference generator - Remove unnecessary line breaks. - Move `teleport` requirement into the main `require` block. - Embed the template. - Accommodate characters that exceed one byte in `prepareDescription`. - Use a no-allocation alternative to strings.Join in `colNameList`.
camscale
reviewed
Nov 24, 2025
| --- | ||
|
|
||
| The Access Monitoring event reference includes a list of Access Monitoring | ||
| events that you can query and view in reports, along with examples of @tctl@ |
Contributor
There was a problem hiding this comment.
Sorry, I missed this first time around - are these @ symbols meant to be backticks? i don't think this file went through the substitution so perhaps this is deliberate.
Contributor
Author
There was a problem hiding this comment.
Ah, good catch, thanks. This file was originally part of the template before I opened the PR, but I forgot to remove the @s when I extracted it. Fixed in #61770
zmb3
pushed a commit
that referenced
this pull request
Nov 24, 2025
Backports #61632 * Generate an Access Monitoring event reference Closes #60074 Use the getters we declared to access protobuf-generated event structs in order to create Athena views for Access Monitoring events, populating a template with the event structs and including examples of `tctl audit query exec` queries. Add Make targets to generate the page and check that it was generated. Add a step to the `Lint (Proto)` job to check that this was generated. * Clean up the event schema reference generator - Remove unnecessary line breaks. - Move `teleport` requirement into the main `require` block. - Embed the template. - Accommodate characters that exceed one byte in `prepareDescription`. - Use a no-allocation alternative to strings.Join in `colNameList`.
ptgott
added a commit
that referenced
this pull request
Nov 25, 2025
In #61632, the Access Monitoring event reference generator originally replaced `@` characters in a template with backticks before executing it, and the frontmatter and introduction of the guide were part of the template. While this change took a different approach, extracting the frontmatter and introduction into a separate file, and no longer replacing `@` characters, the `@` characters weren't removed from the file. This change fixes the stray `@` characters.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2025
In #61632, the Access Monitoring event reference generator originally replaced `@` characters in a template with backticks before executing it, and the frontmatter and introduction of the guide were part of the template. While this change took a different approach, extracting the frontmatter and introduction into a separate file, and no longer replacing `@` characters, the `@` characters weren't removed from the file. This change fixes the stray `@` characters.
backport-bot-workflows bot
pushed a commit
that referenced
this pull request
Nov 26, 2025
In #61632, the Access Monitoring event reference generator originally replaced `@` characters in a template with backticks before executing it, and the frontmatter and introduction of the guide were part of the template. While this change took a different approach, extracting the frontmatter and introduction into a separate file, and no longer replacing `@` characters, the `@` characters weren't removed from the file. This change fixes the stray `@` characters.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 1, 2025
In #61632, the Access Monitoring event reference generator originally replaced `@` characters in a template with backticks before executing it, and the frontmatter and introduction of the guide were part of the template. While this change took a different approach, extracting the frontmatter and introduction into a separate file, and no longer replacing `@` characters, the `@` characters weren't removed from the file. This change fixes the stray `@` characters.
cthach
pushed a commit
that referenced
this pull request
Dec 1, 2025
In #61632, the Access Monitoring event reference generator originally replaced `@` characters in a template with backticks before executing it, and the frontmatter and introduction of the guide were part of the template. While this change took a different approach, extracting the frontmatter and introduction into a separate file, and no longer replacing `@` characters, the `@` characters weren't removed from the file. This change fixes the stray `@` characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60074
Use the getters we declared to access protobuf-generated event structs in order to create Athena views for Access Monitoring events, populating a template with the event structs and including examples of
tctl audit query execqueries.Add Make targets to generate the page and check that it was generated. Add a step to the
Lint (Proto)job to check that this was generated.