Conversation
|
@avatus - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
|
i know there are generated files involved, but 5k lines? is that normal? |
integrations/terraform/protoc-gen-terraform-discoveryconfig.yaml
Outdated
Show resolved
Hide resolved
.../pages/reference/infrastructure-as-code/terraform-provider/data-sources/discovery_config.mdx
Show resolved
Hide resolved
integrations/terraform/tfschema/discoveryconfig/v1/custom_types.go
Outdated
Show resolved
Hide resolved
hugoShaka
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
hugoShaka
requested review from
camscale,
doggydogworld,
fheinecke,
klizhentas,
r0mant,
rosstimothy,
russjones and
zmb3
as code owners
hugoShaka
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
public-teleport-github-review-bot
bot
removed request for
marcoandredinis and
tigrato
| install_params = { | ||
| join_method = "iam" | ||
| join_token = "aws-discovery-token" | ||
| script_name = "default-installer" | ||
| } |
There was a problem hiding this comment.
There are a couple of values that are set when the install_params is not set in the teleport.yaml/discovery_service.aws[].install or in discovery_config.spec.aws[].install.
As an example, if the install_params is not set, it will set the:
- enroll_mode to
scriptenum value - install_teleport to
true
I'm not sure we can do the same logic here, but if possible let's at least ensure the example value is set to those values.
There was a problem hiding this comment.
Can we update the bot to ignore this generated code when sizing the PR?
There was a problem hiding this comment.
You got pulled in not because of the PR size bot but because I bumped the protoc-gen-tfschema versa and it was referenced in a GHA job. Any gha workflow requires approval from codeowners.
I think file is already ignored, else the PR would have pulled all admins initially, and not only when the version got bumped.
There was a problem hiding this comment.
Hrmm are you sure, the label is size/xl and the bot left a comment asking for an admin reviewer.
There was a problem hiding this comment.
I'll check the size bot rules, I had changes to do anyway, but you did get pulled because of my commit:
Closes #60809 This will allow users to manage the DiscoveryConfig resource via terraform
There no need to roll our own JoinMethod type, the join method underlying type is a regular string. We can tell the schema geenrator to use the native string type instead of having to write our own types (which is error prone, we already messed up the bool option once). This commit requires the protoc-gen-terraform v3.0.3 (with a schema override fix, unreleased as of now). protoc-gen-tfschema 3.0.2 -> 3.0.3
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
* Support DiscoveryConfig in terraform provider Closes #60809 This will allow users to manage the DiscoveryConfig resource via terraform * Use TF types overrides instead of custom types There no need to roll our own JoinMethod type, the join method underlying type is a regular string. We can tell the schema geenrator to use the native string type instead of having to write our own types (which is error prone, we already messed up the bool option once). This commit requires the protoc-gen-terraform v3.0.3 (with a schema override fix, unreleased as of now). protoc-gen-tfschema 3.0.2 -> 3.0.3 --------- Co-authored-by: hugoShaka <hugo.hervieux@goteleport.com>
6 participants
Closes #60809
This will allow users to manage the DiscoveryConfig resource via terraform
Changelog: DiscoveryConfig resources can now be managed via the Teleport Terraform Provider