Conversation
avatus
approved these changes
Nov 26, 2025
hugoShaka
commented
Nov 26, 2025
| @@ -1 +1 @@ | |||
| v3.0.2 | |||
Contributor
Author
There was a problem hiding this comment.
I'll cut the release once the PR is merged. I'm just lazy and don't want to do a second PR just to bump the version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
schema_typesconfiguration by:Required for: gravitational/teleport#61680
Demo
This is my config
This is the code before this change:
{ a, ok := tf.Attrs["join_method"] if !ok { diags.Append(attrReadMissingDiag{"DiscoveryConfig.spec.aws.Params.JoinMethod"}) } else { v, ok := a.(github.com_hashicorp_terraform_plugin_framework_types.String) if !ok { diags.Append(attrReadConversionFailureDiag{"DiscoveryConfig.spec.aws.Params.JoinMethod", "github.com/hashicorp/terraform-plugin-framework/types.String"}) } else { // this is the wrong type, should match the type from `cast_from_type` but is trying to find the type in the proto package (doesn't make sense as we are in an override) var t github.com_gravitational_teleport_api_gen_proto_go_teleport_discoveryconfig_v1.JoinMethod if !v.Null && !v.Unknown { // this is using the `cast_to` instead of the `cast_from` t = string(v.Value) } obj.JoinMethod = t } } }This is the code after this change:
{ a, ok := tf.Attrs["join_method"] if !ok { diags.Append(attrReadMissingDiag{"DiscoveryConfig.spec.aws.Params.JoinMethod"}) } else { v, ok := a.(github.com_hashicorp_terraform_plugin_framework_types.String) if !ok { diags.Append(attrReadConversionFailureDiag{"DiscoveryConfig.spec.aws.Params.JoinMethod", "github.com/hashicorp/terraform-plugin-framework/types.String"}) } else { var t github.com_gravitational_teleport_api_types.JoinMethod if !v.Null && !v.Unknown { t = github.com_gravitational_teleport_api_types.JoinMethod(v.Value) } obj.JoinMethod = t } } }