[v17] fix: use DeleteAllPrincipalAssignments to delete principal assignment from cache#61313
Merged
flyinghermit merged 3 commits intobranch/v17from Nov 13, 2025
Merged
[v17] fix: use DeleteAllPrincipalAssignments to delete principal assignment from cache#61313flyinghermit merged 3 commits intobranch/v17from
DeleteAllPrincipalAssignments to delete principal assignment from cache#61313flyinghermit merged 3 commits intobranch/v17from
Conversation
…gnmentExecutor.deleteAll
flyinghermit
changed the title
DeleteAllPrincipalAssignments in cache identityCenterPrincipalAssignmentExecutor.deleteAllDeleteAllPrincipalAssignments to delete principal assignment from cache
smallinsky
approved these changes
Nov 13, 2025
rosstimothy
approved these changes
Nov 13, 2025
public-teleport-github-review-bot
bot
removed request for
espadolini,
nicholasmarais1158 and
tcsc
espadolini
changed the title
DeleteAllPrincipalAssignments to delete principal assignment from cacheDeleteAllPrincipalAssignments to delete principal assignment from cache
espadolini
approved these changes
Nov 13, 2025
- use stream.Collect - add comment in test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During first cache start, cache executer loops through each of the supported resource and builds up cache with the following tasks:
The cache
identityCenterPrincipalAssignmentExecutor.deleteAllmethod was erroneously usingDeleteAllIdentityCenterAccountsinstead ofDeleteAllPrincipalAssignmentsmethod, deleting the all the account from the cache. The order of the execution is not in a linear order. Depending on whether principalAssignment executer runs before or after the account executer, the behaviour accounted for situation where accounts may persist or be emptied from the cache in a random fashion.This issue only affects v17 branch.
The first bug was introduced here where
DeleteAllIdentityCenterAccountswas used instead ofDeleteAllAccountAssignments. This was fixed with this PR, which itself introduced this new bug usingDeleteAllIdentityCenterAccountsinstead ofDeleteAllPrincipalAssignments.changelog: Fixed an issue with the Identity Center resource cache that could cause the account resources to be deleted from the cache.