Skip to content

[v18] kube: register metrics api resources#60971

Merged
tigrato merged 1 commit intobranch/v18from
tigrato/metricsv18
Nov 4, 2025
Merged

[v18] kube: register metrics api resources#60971
tigrato merged 1 commit intobranch/v18from
tigrato/metricsv18

Conversation

@tigrato
Copy link
Copy Markdown
Contributor

@tigrato tigrato commented Nov 3, 2025

Backport of #60683 to branch/v18

Changelog: Fixed Kubernetes metrics API unmarshaling errors causing kubectl top commands to fail in certain scenarios.

* kube: register metrics api resources

kubectl is moving towards using protobuf behind the scenes for kubectl
top, this means our fallback unstrucutred.Unstructured object couldn't unmarshal
the protobuf and failed.

This PR properly registers the metrics apis making them available for
unmarshaling.

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>

* add unit tests

---------

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
@tigrato tigrato enabled auto-merge November 3, 2025 23:35
@tigrato tigrato changed the title [v18] kube: register metrics api resources ) [v18] kube: register metrics api resources Nov 4, 2025
@tigrato tigrato disabled auto-merge November 4, 2025 10:01
@tigrato tigrato enabled auto-merge November 4, 2025 10:01
@tigrato tigrato added this pull request to the merge queue Nov 4, 2025
Merged via the queue into branch/v18 with commit 112758d Nov 4, 2025
44 of 48 checks passed
@tigrato tigrato deleted the tigrato/metricsv18 branch November 4, 2025 17:29
This was referenced Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants