Merged
Conversation
kubectl is moving towards using protobuf behind the scenes for kubectl top, this means our fallback unstrucutred.Unstructured object couldn't unmarshal the protobuf and failed. This PR properly registers the metrics apis making them available for unmarshaling. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
force-pushed
the
tigrato/register-metrics-schema
branch
from
f94d6a7 to
6848cea
Compare
tigrato
requested review from
r0mant,
rosstimothy,
russjones and
zmb3
as code owners
rana
approved these changes
Oct 28, 2025
rosstimothy
reviewed
Oct 28, 2025
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
Can we add test coverage?
rosstimothy
approved these changes
Nov 3, 2025
public-teleport-github-review-bot
bot
removed the request for review
from ravicious
Contributor
Closed
tigrato
added a commit
that referenced
this pull request
Nov 3, 2025
* kube: register metrics api resources kubectl is moving towards using protobuf behind the scenes for kubectl top, this means our fallback unstrucutred.Unstructured object couldn't unmarshal the protobuf and failed. This PR properly registers the metrics apis making them available for unmarshaling. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * add unit tests --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
* kube: register metrics api resources kubectl is moving towards using protobuf behind the scenes for kubectl top, this means our fallback unstrucutred.Unstructured object couldn't unmarshal the protobuf and failed. This PR properly registers the metrics apis making them available for unmarshaling. * add unit tests --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
mmcallister
pushed a commit
that referenced
this pull request
Nov 19, 2025
* kube: register metrics api resources kubectl is moving towards using protobuf behind the scenes for kubectl top, this means our fallback unstrucutred.Unstructured object couldn't unmarshal the protobuf and failed. This PR properly registers the metrics apis making them available for unmarshaling. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * add unit tests --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
mmcallister
pushed a commit
that referenced
this pull request
Nov 20, 2025
* kube: register metrics api resources kubectl is moving towards using protobuf behind the scenes for kubectl top, this means our fallback unstrucutred.Unstructured object couldn't unmarshal the protobuf and failed. This PR properly registers the metrics apis making them available for unmarshaling. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * add unit tests --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kubectl is moving towards using protobuf behind the scenes for kubectl top, this means our fallback
unstrucutred.Unstructuredobject couldn't unmarshal the protobuf and failed.This PR properly registers the metrics apis making them available for unmarshaling.
Changelog: Fixed Kubernetes metrics API unmarshaling errors causing kubectl top commands to fail in certain scenarios.