Revert setOwnersEligibility setMemberEligibility functionality#60556
Merged
smallinsky merged 2 commits intomasterfrom Oct 24, 2025
Merged
Revert setOwnersEligibility setMemberEligibility functionality#60556smallinsky merged 2 commits intomasterfrom
smallinsky merged 2 commits intomasterfrom
Conversation
smallinsky
force-pushed
the
smallinsky/revert-set_eligibility_on_upsert
branch
from
d867b73 to
a8980fd
Compare
smallinsky
force-pushed
the
smallinsky/revert-set_eligibility_on_upsert
branch
from
a8980fd to
6cf6921
Compare
kopiczko
approved these changes
Oct 24, 2025
flyinghermit
approved these changes
Oct 24, 2025
rosstimothy
approved these changes
Oct 24, 2025
public-teleport-github-review-bot
bot
removed request for
camscale and
fspmarshall
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
@smallinsky See the table below for backport results.
|
mmcallister
pushed a commit
that referenced
this pull request
Nov 6, 2025
mmcallister
pushed a commit
that referenced
this pull request
Nov 19, 2025
mmcallister
pushed a commit
that referenced
this pull request
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Revert #58659 functionality.
The setting default eligibility status on Upsert call intended to reduce Ineligibility cycle after importing large collection from entraID directory.
but this approach is very hard to reason about where the eligibility reconsider expect to reset eligibility to
IneligibleStatus_INELIGIBLE_STATUS_UNSPECIFIEDthat creates potentials bugs https://github.com/gravitational/teleport.e/blob/master/lib/accesslist/service.go#L2454Related: test coverage https://github.com/gravitational/teleport.e/pull/7464
changelog: Fix an issue where the eligibility reconsideration flow could continuously reset the Owner’s eligibility status when the Access List contains a dangling reference to a non-existent user