Align Access Lisit Owners/Members Eligibility status.#58659
Merged
smallinsky merged 2 commits intomasterfrom Sep 5, 2025
Merged
Align Access Lisit Owners/Members Eligibility status.#58659smallinsky merged 2 commits intomasterfrom
smallinsky merged 2 commits intomasterfrom
Conversation
smallinsky
force-pushed
the
smallinsky/access-list-ilegibility-preset
branch
from
f07ba52 to
eba5549
Compare
Contributor
Author
|
friendly ping @flyinghermit @creack @tigrato |
tigrato
approved these changes
Sep 4, 2025
flyinghermit
approved these changes
Sep 4, 2025
smallinsky
added
the
no-changelog
smallinsky
force-pushed
the
smallinsky/access-list-ilegibility-preset
branch
from
eba5549 to
c4c60c6
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
@smallinsky See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Preset the owners/membership Eligibility status to avoid updating the ACL/Members objects via eligibility reconciler.
What is
EligibilityStatus ?This field doesn't have any impact on RBAC calucation is only consumed by FE to display nice indicator on the owner/members FE Access List view page to render icon that indicating that particular user doesn't meeting access list eligibility criteria.
In https://github.com/gravitational/teleport.e/blob/master/lib/accesslist/reconciler_ineligible_status.go we have watcher on each member/acl change to update the eligibility status. When access list is simple (don't have any requiremnts or member don't use expiration) the
reconciler_ineligible_statusis triggered to just updated the status from "", to Eligible.