Conversation
cthach
added
go
Signed-off-by: Chris Thach <chris.thach@goteleport.com>
cthach
force-pushed
the
cthach/bump-go-1.24.8-v17
branch
from
c4d7d9d to
8d3653e
Compare
Signed-off-by: Chris Thach <chris.thach@goteleport.com>
cthach
force-pushed
the
cthach/bump-go-1.24.8-v17
branch
from
65b8ad8 to
8775d3a
Compare
cthach
requested review from
hugoShaka,
r0mant,
rosstimothy,
russjones,
tigrato and
zmb3
as code owners
cthach
requested review from
camscale,
doggydogworld,
fheinecke and
strideynet
as code owners
|
Holding off until https://github.com/gravitational/teleport.e/pull/7412 is merged |
Signed-off-by: Chris Thach <chris.thach@goteleport.com>
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
It looks like the examples updates were dropped here?
One is still on Go 1.22 Others are on Go 1.23.0 teleport/examples/access-plugin-minimal/go.mod Lines 3 to 4 in 9ffcfa1 teleport/examples/api-sync-roles/go.mod Lines 3 to 4 in 9ffcfa1 teleport/examples/desktop-registration/go.mod Lines 3 to 4 in 9ffcfa1 teleport/examples/go-client/go.mod Lines 3 to 4 in 9ffcfa1 teleport/examples/service-discovery-api-client/go.mod Lines 3 to 4 in 9ffcfa1 I left them out because I assumed it was deliberate. Did you want me to try bumping them all to 1.24.9? |
I think we've just historically been bad about updating the examples. Let's bump them to the latest version here and we can reconsider our approach going forward. |
Signed-off-by: Chris Thach <chris.thach@goteleport.com>
github-actions
bot
requested review from
espadolini,
marcoandredinis,
rosstimothy and
zmb3
5 participants
Backports #60094.
Changelog: Updated Go to 1.24.9.