Conversation
0ff7623 to
f96aa6b
Compare
0032ad2 to
2758065
Compare
Signed-off-by: Chris Thach <chris.thach@goteleport.com>
2758065 to
c3a63e3
Compare
|
golang/go#75828 (comment) this will completely break clusters whose name is longer than 31 characters, let's wait and hope they relax the checks? |
I'm good with holding off. Btw, here are the full validation rules: Besides empty names and clusters with long names, what other rules affect us? Would be good to know |
Pull request was converted to draft
|
Pausing this update for now until a new Go version is released. |
The only one we were aware of was the long labels (#52508), I don't think we considered the implications empty SANs until now. |
|
Looks like the DNS SANs validation is being relaxed after causing breakage: https://go-review.googlesource.com/c/go/+/710735 I'll wait for it to get pulled into a release before I continue with the updating. |
Signed-off-by: Chris Thach <chris.thach@goteleport.com>
* chore: Bump Go to 1.25.2 ⬆️ Signed-off-by: Chris Thach <chris.thach@goteleport.com> * fix: Bump to Go 1.25.3. Revert handling of breaking changes. Signed-off-by: Chris Thach <chris.thach@goteleport.com> --------- Signed-off-by: Chris Thach <chris.thach@goteleport.com>
* chore: Bump Go to 1.25.2 ⬆️ Signed-off-by: Chris Thach <chris.thach@goteleport.com> * fix: Bump to Go 1.25.3. Revert handling of breaking changes. Signed-off-by: Chris Thach <chris.thach@goteleport.com> --------- Signed-off-by: Chris Thach <chris.thach@goteleport.com>
* chore: Bump Go to 1.25.2 ⬆️ Signed-off-by: Chris Thach <chris.thach@goteleport.com> * fix: Bump to Go 1.25.3. Revert handling of breaking changes. Signed-off-by: Chris Thach <chris.thach@goteleport.com> --------- Signed-off-by: Chris Thach <chris.thach@goteleport.com>
* chore: Bump Go to 1.25.2 ⬆️ Signed-off-by: Chris Thach <chris.thach@goteleport.com> * fix: Bump to Go 1.25.3. Revert handling of breaking changes. Signed-off-by: Chris Thach <chris.thach@goteleport.com> --------- Signed-off-by: Chris Thach <chris.thach@goteleport.com>
Changelog: Updated Go to 1.25.3.
Skipped Go 1.25.2 because it had breaking changes. Go 1.25.3 reverts those breaking changes while including most of security/bug fixes.
Will be manually backported to previous release branches since they require Go 1.24.x.