Skip to content

Bump Go to 1.25.3 ⬆️#60094

Merged
cthach merged 4 commits intomasterfrom
cthach/bump-go-1.25.2
Oct 14, 2025
Merged

Bump Go to 1.25.3 ⬆️#60094
cthach merged 4 commits intomasterfrom
cthach/bump-go-1.25.2

Conversation

@cthach
Copy link
Copy Markdown
Contributor

@cthach cthach commented Oct 9, 2025

Changelog: Updated Go to 1.25.3.

Skipped Go 1.25.2 because it had breaking changes. Go 1.25.3 reverts those breaking changes while including most of security/bug fixes.

Will be manually backported to previous release branches since they require Go 1.24.x.

@cthach cthach self-assigned this Oct 9, 2025
@cthach cthach added backport-required go Issues related to Go builds/tooling dependencies Pull requests that update a dependency file size/sm backport/branch/v16 backport/branch/v17 backport/branch/v18 labels Oct 9, 2025
@cthach cthach force-pushed the cthach/bump-go-1.25.2 branch 2 times, most recently from 0ff7623 to f96aa6b Compare October 9, 2025 17:06
@cthach cthach force-pushed the cthach/bump-go-1.25.2 branch from 0032ad2 to 2758065 Compare October 9, 2025 18:17
Signed-off-by: Chris Thach <chris.thach@goteleport.com>
@espadolini
Copy link
Copy Markdown
Contributor

golang/go#75828 (comment) this will completely break clusters whose name is longer than 31 characters, let's wait and hope they relax the checks?

@cthach
Copy link
Copy Markdown
Contributor Author

cthach commented Oct 9, 2025

golang/go#75828 (comment) this will completely break clusters whose name is longer than 31 characters, let's wait and hope they relax the checks?

I'm good with holding off. Btw, here are the full validation rules:

// domainNameValid does minimal domain name validity checking. In particular it
// enforces the following properties:
//   - names cannot have the trailing period
//   - names can only have a leading period if constraint is true
//   - names must be <= 253 characters
//   - names cannot have empty labels
//   - names cannot labels that are longer than 63 characters

Besides empty names and clusters with long names, what other rules affect us? Would be good to know

@cthach cthach marked this pull request as draft October 9, 2025 19:50
auto-merge was automatically disabled October 9, 2025 19:50

Pull request was converted to draft

@cthach
Copy link
Copy Markdown
Contributor Author

cthach commented Oct 9, 2025

Pausing this update for now until a new Go version is released.

@espadolini
Copy link
Copy Markdown
Contributor

what other rules affect us?

The only one we were aware of was the long labels (#52508), I don't think we considered the implications empty SANs until now.

Comment thread lib/service/service.go Outdated
@cthach
Copy link
Copy Markdown
Contributor Author

cthach commented Oct 10, 2025

Looks like the DNS SANs validation is being relaxed after causing breakage: https://go-review.googlesource.com/c/go/+/710735

I'll wait for it to get pulled into a release before I continue with the updating.

@cthach cthach changed the title Bump Go to 1.25.2 ⬆️ Bump Go to 1.25.3 ⬆️ Oct 14, 2025
Signed-off-by: Chris Thach <chris.thach@goteleport.com>
@cthach cthach marked this pull request as ready for review October 14, 2025 14:07
@cthach cthach requested a review from espadolini October 14, 2025 14:07
@cthach cthach added the security Security Issues label Oct 14, 2025
@cthach cthach enabled auto-merge October 14, 2025 14:37
@cthach cthach added this pull request to the merge queue Oct 14, 2025
Merged via the queue into master with commit 72716be Oct 14, 2025
47 checks passed
@cthach cthach deleted the cthach/bump-go-1.25.2 branch October 14, 2025 15:20
mmcallister pushed a commit that referenced this pull request Nov 6, 2025
* chore: Bump Go to 1.25.2 ⬆️

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

* fix: Bump to Go 1.25.3. Revert handling of breaking changes.

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

---------

Signed-off-by: Chris Thach <chris.thach@goteleport.com>
rhammonds-teleport pushed a commit that referenced this pull request Nov 6, 2025
* chore: Bump Go to 1.25.2 ⬆️

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

* fix: Bump to Go 1.25.3. Revert handling of breaking changes.

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

---------

Signed-off-by: Chris Thach <chris.thach@goteleport.com>
mmcallister pushed a commit that referenced this pull request Nov 19, 2025
* chore: Bump Go to 1.25.2 ⬆️

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

* fix: Bump to Go 1.25.3. Revert handling of breaking changes.

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

---------

Signed-off-by: Chris Thach <chris.thach@goteleport.com>
mmcallister pushed a commit that referenced this pull request Nov 20, 2025
* chore: Bump Go to 1.25.2 ⬆️

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

* fix: Bump to Go 1.25.3. Revert handling of breaking changes.

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

---------

Signed-off-by: Chris Thach <chris.thach@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-required dependencies Pull requests that update a dependency file go Issues related to Go builds/tooling security Security Issues size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants