MWI: Add service health to bot heartbeats#60093
Merged
Conversation
boxofrad
force-pushed
the
boxofrad/tbot-heartbeat-wait-for-services
branch
from
ed5530d to
d011f22
Compare
boxofrad
force-pushed
the
boxofrad/tbot-heartbeat-include-service-health
branch
from
0f4dda5 to
6141ee9
Compare
timothyb89
approved these changes
Oct 10, 2025
rana
approved these changes
Oct 10, 2025
public-teleport-github-review-bot
bot
removed request for
nicholasmarais1158 and
strideynet
nicholasmarais1158
approved these changes
Oct 10, 2025
strideynet
requested changes
Oct 10, 2025
boxofrad
force-pushed
the
boxofrad/tbot-heartbeat-include-service-health
branch
from
6141ee9 to
77ae1ff
Compare
boxofrad
force-pushed
the
boxofrad/tbot-heartbeat-wait-for-services
branch
from
d011f22 to
a9b7123
Compare
boxofrad
force-pushed
the
boxofrad/tbot-heartbeat-include-service-health
branch
from
77ae1ff to
3418e6f
Compare
boxofrad
force-pushed
the
boxofrad/tbot-heartbeat-wait-for-services
branch
from
a9b7123 to
022c3ae
Compare
nicholasmarais1158
approved these changes
Oct 13, 2025
Comment on lines
+260
to
+263
| if storeHeartbeatExtras() { | ||
| // Overwrite the service health. | ||
| instance.Status.ServiceHealth = req.ServiceHealth | ||
| } |
Contributor
There was a problem hiding this comment.
Feels like we should give this some test coverage. It's the sort of thing nobody uses or thinks about until the day when it's really needed and wont work because of some subtle regression which snuck in over time.
strideynet
approved these changes
Oct 13, 2025
boxofrad
force-pushed
the
boxofrad/tbot-heartbeat-wait-for-services
branch
from
022c3ae to
5878e1e
Compare
boxofrad
force-pushed
the
boxofrad/tbot-heartbeat-include-service-health
branch
from
cc7b40f to
4193b03
Compare
boxofrad
force-pushed
the
boxofrad/tbot-heartbeat-wait-for-services
branch
from
5878e1e to
16e56e8
Compare
boxofrad
force-pushed
the
boxofrad/tbot-heartbeat-include-service-health
branch
from
4193b03 to
c33b482
Compare
boxofrad
force-pushed
the
boxofrad/tbot-heartbeat-wait-for-services
branch
from
16e56e8 to
d9aef19
Compare
boxofrad
force-pushed
the
boxofrad/tbot-heartbeat-include-service-health
branch
from
c33b482 to
4f3f7da
Compare
Base automatically changed from
boxofrad/tbot-heartbeat-wait-for-services
to
master
October 21, 2025 10:22
boxofrad
force-pushed
the
boxofrad/tbot-heartbeat-include-service-health
branch
from
4f3f7da to
5c04887
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
boxofrad
added a commit
that referenced
this pull request
Oct 22, 2025
Backport #60093 to branch/v18
boxofrad
added a commit
that referenced
this pull request
Oct 22, 2025
Backport #60093 to branch/v17
boxofrad
added a commit
that referenced
this pull request
Oct 29, 2025
Backport #60093 to branch/v18
boxofrad
added a commit
that referenced
this pull request
Oct 29, 2025
Backport #60093 to branch/v17
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
* [v17] MWI: Automatically report service statuses in oneshot mode Backport #60148 to branch/v17 * [v17] MWI: Add `AllServicesReported` method to `readyz.Register` Backport #60059 to branch/v17 * [v17] MWI: Wait for service health before sending first heartbeat Backport #60087 to branch/v17 * [v17] MWI: Add service health to bot heartbeats Backport #60093 to branch/v17 * [v17] MWI: Simpler auto-generated `tbot` service names Backport #60052 to branch/v17 * Fix `testing/synctest` on CI * Fix linting of synctest files on CI * [v17] MWI: Fix flaky test in SPIFFE Workload APIs Backport #60668 to branch/v17
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
* [v18] MWI: Automatically report service statuses in oneshot mode Backport #60148 to branch/v18 * [v18] MWI: Add `AllServicesReported` method to `readyz.Register` Backport #60059 to branch/v18 * [v18] MWI: Wait for service health before sending first heartbeat Backport #60087 to branch/v18 * [v18] MWI: Add service health to bot heartbeats Backport #60093 to branch/v18 * [v18] MWI: Simpler auto-generated `tbot` service names Backport #60052 to branch/v18 * Fix linting of synctest files on CI * [v18] MWI: Fix flaky test in SPIFFE Workload APIs Backport #60668 to branch/v18
mmcallister
pushed a commit
that referenced
this pull request
Nov 6, 2025
* Add protobuf definitions for service health * Track `UpdatedAt` timestamp on service statuses * Track service type against status * Send service health with bot status * Store service health against bot instance * Add `TELEPORT_DISABLE_TBOT_HEARTBEAT_EXTRAS` control
mmcallister
pushed a commit
that referenced
this pull request
Nov 19, 2025
* Add protobuf definitions for service health * Track `UpdatedAt` timestamp on service statuses * Track service type against status * Send service health with bot status * Store service health against bot instance * Add `TELEPORT_DISABLE_TBOT_HEARTBEAT_EXTRAS` control
mmcallister
pushed a commit
that referenced
this pull request
Nov 20, 2025
* Add protobuf definitions for service health * Track `UpdatedAt` timestamp on service statuses * Track service type against status * Send service health with bot status * Store service health against bot instance * Add `TELEPORT_DISABLE_TBOT_HEARTBEAT_EXTRAS` control
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: RFD 222: Bot Instances at Scale for more information.
changelog: MWI: Health of
tbot's services is now reported to the auth server in heartbeats