MWI: Add AllServicesReported method to readyz.Registry#60059
Merged
Conversation
boxofrad
added
machine-id
no-changelog
boxofrad
changed the title
AllServicesReported method to readyz.RegisterAllServicesReported method to readyz.Registry
strideynet
approved these changes
Oct 9, 2025
boxofrad
force-pushed
the
boxofrad/tbot-readyz-block
branch
from
2a25403 to
48b0203
Compare
timothyb89
approved these changes
Oct 10, 2025
public-teleport-github-review-bot
bot
removed the request for review
from doggydogworld
boxofrad
force-pushed
the
boxofrad/tbot-readyz-block
branch
from
48b0203 to
ec9ad91
Compare
boxofrad
force-pushed
the
boxofrad/tbot-oneshot-status
branch
from
d907f78 to
191382e
Compare
boxofrad
force-pushed
the
boxofrad/tbot-readyz-block
branch
from
ec9ad91 to
2afeaa2
Compare
This method will be used by the heartbeat service to wait until services have reported their initial status (with a timeout) before submitting the initial heartbeat. Otherwise, we'd potentially report all services as "initializing" for 30 minutes in daemon mode, or forever in long-shot mode.
boxofrad
force-pushed
the
boxofrad/tbot-readyz-block
branch
from
2afeaa2 to
f763e57
Compare
boxofrad
added a commit
that referenced
this pull request
Oct 22, 2025
Backport #60059 to branch/v18
boxofrad
added a commit
that referenced
this pull request
Oct 22, 2025
Backport #60059 to branch/v17
boxofrad
added a commit
that referenced
this pull request
Oct 29, 2025
Backport #60059 to branch/v18
boxofrad
added a commit
that referenced
this pull request
Oct 29, 2025
Backport #60059 to branch/v17
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
* [v17] MWI: Automatically report service statuses in oneshot mode Backport #60148 to branch/v17 * [v17] MWI: Add `AllServicesReported` method to `readyz.Register` Backport #60059 to branch/v17 * [v17] MWI: Wait for service health before sending first heartbeat Backport #60087 to branch/v17 * [v17] MWI: Add service health to bot heartbeats Backport #60093 to branch/v17 * [v17] MWI: Simpler auto-generated `tbot` service names Backport #60052 to branch/v17 * Fix `testing/synctest` on CI * Fix linting of synctest files on CI * [v17] MWI: Fix flaky test in SPIFFE Workload APIs Backport #60668 to branch/v17
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
* [v18] MWI: Automatically report service statuses in oneshot mode Backport #60148 to branch/v18 * [v18] MWI: Add `AllServicesReported` method to `readyz.Register` Backport #60059 to branch/v18 * [v18] MWI: Wait for service health before sending first heartbeat Backport #60087 to branch/v18 * [v18] MWI: Add service health to bot heartbeats Backport #60093 to branch/v18 * [v18] MWI: Simpler auto-generated `tbot` service names Backport #60052 to branch/v18 * Fix linting of synctest files on CI * [v18] MWI: Fix flaky test in SPIFFE Workload APIs Backport #60668 to branch/v18
mmcallister
pushed a commit
that referenced
this pull request
Nov 6, 2025
This method will be used by the heartbeat service to wait until services have reported their initial status (with a timeout) before submitting the initial heartbeat. Otherwise, we'd potentially report all services as "initializing" for 30 minutes in daemon mode, or forever in long-shot mode.
mmcallister
pushed a commit
that referenced
this pull request
Nov 19, 2025
This method will be used by the heartbeat service to wait until services have reported their initial status (with a timeout) before submitting the initial heartbeat. Otherwise, we'd potentially report all services as "initializing" for 30 minutes in daemon mode, or forever in long-shot mode.
mmcallister
pushed a commit
that referenced
this pull request
Nov 20, 2025
This method will be used by the heartbeat service to wait until services have reported their initial status (with a timeout) before submitting the initial heartbeat. Otherwise, we'd potentially report all services as "initializing" for 30 minutes in daemon mode, or forever in long-shot mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method will be used by the heartbeat service to wait until services have reported their initial status (with a timeout) before submitting the initial heartbeat. Otherwise, we'd potentially report all services as "initializing" for 30 minutes in daemon mode, or forever in long-shot mode.