Merged
Conversation
Joerger
force-pushed
the
joerger/fix-eice-connections
branch
from
b063fad to
b4f6629
Compare
zmb3
reviewed
Oct 3, 2025
Collaborator
There was a problem hiding this comment.
Can we write a test that would have caught this bug?
Contributor
Author
There was a problem hiding this comment.
I added a basic test for CheckDefaults. I'm not sure about adding a more in-depth test (e.g. fully mocked EICE flow in an integration test) given that the EICE flow is deprecated.
espadolini
approved these changes
Oct 6, 2025
| } | ||
| if s.TargetServer.IsOpenSSHNode() { | ||
| switch s.TargetServer.GetSubKind() { | ||
| case types.SubKindTeleportNode: |
Contributor
There was a problem hiding this comment.
Should we add a "" case too just to be safe? I'm not sure we enforce that the subkind must be "teleport" for regular node heartbeats.
Suggested change
| case types.SubKindTeleportNode: | |
| case types.SubKindTeleportNode, "": |
Contributor
Author
There was a problem hiding this comment.
SubKind() defaults to Teleport Node if unset:
Lines 178 to 182 in 5e2b4a7
Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
marcoandredinis
approved these changes
Oct 7, 2025
Contributor
marcoandredinis
left a comment
marcoandredinis
left a comment
There was a problem hiding this comment.
Just tested this and it works 👍
public-teleport-github-review-bot
bot
removed request for
danielashare and
rosstimothy
Contributor
Joerger
added a commit
that referenced
this pull request
Oct 9, 2025
* Don't require agentless signer during CheckAndSetDefaults for OpenSSH EICE nodes. * Add CheckDefaults test. * Update lib/reversetunnel/local_cluster.go Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com> --------- Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
Joerger
added a commit
that referenced
this pull request
Oct 9, 2025
* Don't require agentless signer during CheckAndSetDefaults for OpenSSH EICE nodes. * Add CheckDefaults test. * Update lib/reversetunnel/local_cluster.go Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com> --------- Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
Joerger
added a commit
that referenced
this pull request
Oct 9, 2025
* Don't require agentless signer during CheckAndSetDefaults for OpenSSH EICE nodes. * Add CheckDefaults test. * Update lib/reversetunnel/local_cluster.go Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com> --------- Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
Joerger
added a commit
that referenced
this pull request
Oct 9, 2025
* Don't require agentless signer during CheckAndSetDefaults for OpenSSH EICE nodes. * Add CheckDefaults test. * Update lib/reversetunnel/local_cluster.go Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com> --------- Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
rhammonds-teleport
pushed a commit
that referenced
this pull request
Nov 6, 2025
* Don't require agentless signer during CheckAndSetDefaults for OpenSSH EICE nodes. * Add CheckDefaults test. * Update lib/reversetunnel/local_cluster.go Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com> --------- Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix a bug where OpenSSH EICE node connections would fail.
In #58700, we mistakenly began to require
AgentlessSignerto be set for OpenSSH EICE node before it is actually set.Fixes #59922