Make TargetServer a required field in the forwarding server#58700
Merged
Make TargetServer a required field in the forwarding server#58700
TargetServer a required field in the forwarding server#58700Conversation
Joerger
added
no-changelog
rosstimothy
reviewed
Sep 4, 2025
fspmarshall
approved these changes
Sep 8, 2025
Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com>
Joerger
force-pushed
the
joerger/require-target-server
branch
from
dff14c1 to
186dd57
Compare
rosstimothy
approved these changes
Sep 9, 2025
public-teleport-github-review-bot
bot
removed the request for review
from doggydogworld
Contributor
Joerger
added a commit
that referenced
this pull request
Sep 10, 2025
* Make targetServer a required field in the forwarding server. * Remove unused field. * Update serverResolver to never return nil,nil. * Cleanup variables in DialHost. * Restore previous event metadata values; Update comments. * Don't add serverID to principals if it's redundant. * Update lib/proxy/router.go Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com> * Fix lint. * Fix test. --------- Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com>
Joerger
added a commit
that referenced
this pull request
Sep 10, 2025
* Make targetServer a required field in the forwarding server. * Remove unused field. * Update serverResolver to never return nil,nil. * Cleanup variables in DialHost. * Restore previous event metadata values; Update comments. * Don't add serverID to principals if it's redundant. * Update lib/proxy/router.go Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com> * Fix lint. * Fix test. --------- Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com>
Joerger
added a commit
that referenced
this pull request
Sep 10, 2025
* Make targetServer a required field in the forwarding server. * Remove unused field. * Update serverResolver to never return nil,nil. * Cleanup variables in DialHost. * Restore previous event metadata values; Update comments. * Don't add serverID to principals if it's redundant. * Update lib/proxy/router.go Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com> * Fix lint. * Fix test. --------- Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
#58961) * Make targetServer a required field in the forwarding server. * Remove unused field. * Update serverResolver to never return nil,nil. * Cleanup variables in DialHost. * Restore previous event metadata values; Update comments. * Don't add serverID to principals if it's redundant. * Update lib/proxy/router.go * Fix lint. * Fix test. --------- Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
#58960) * Make targetServer a required field in the forwarding server. * Remove unused field. * Update serverResolver to never return nil,nil. * Cleanup variables in DialHost. * Restore previous event metadata values; Update comments. * Don't add serverID to principals if it's redundant. * Update lib/proxy/router.go * Fix lint. * Fix test. --------- Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
#58962) * Make targetServer a required field in the forwarding server. * Remove unused field. * Update serverResolver to never return nil,nil. * Cleanup variables in DialHost. * Restore previous event metadata values; Update comments. * Don't add serverID to principals if it's redundant. * Update lib/proxy/router.go * Fix lint. * Fix test. --------- Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The forwarding server always requires a
TargetServer, but this isn't explicitly covered by the code, resulting in unnecessary additional nil checks and fields.Adapted from #52920