Skip to content

Bump electron from 37.4.0 to 38.2.1 #59812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ravicious merged 6 commits into from
Oct 15, 2025
Merged

Bump electron from 37.4.0 to 38.2.1 #59812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
34b6dc3
Bump electron from 37.4.0 to 38.2.0
dependabot[bot] Oct 2, 2025
673b501
Revert unnecessary updates
ravicious Oct 2, 2025
61c7fdd
Update node-pty to 1.1.0-beta35
ravicious Oct 2, 2025
7ddf387
Update node-abi
ravicious Oct 3, 2025
48bf56e
Bump electron to 38.2.1
ravicious Oct 7, 2025
a9d13e0
Merge branch 'master' into dependabot/npm_and_yarn/electron-38.2.0
ravicious Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions web/packages/teleterm/package.json
View file
Open in desktop
Copy link
Copy Markdown
Member

@ravicious ravicious Oct 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tag builds:

Copy link
Copy Markdown
Member

@ravicious ravicious Oct 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gzdunek So this update works, almost. It breaks window focus on Ubuntu and Fedora. Instead of focusing on the window, it shows a system notification saying "Teleport Connect is ready". I confirmed that this is broken by the Electron update and not recent changes to window management – it works fine on master.

I haven't found an issue related to the focus problem. I can create it, but I think for now we can merge the update? The window doesn't get focus, but at least there's the notification.

Another thing is that because of electron/electron#48321, when running it in a Fedora VM I had to start the app twice because the initial start doesn't show the app window. This should be the case only in VMs.

Screen recordings

Electron 38 (bad)

ubuntu-electron-38.mov

Electron 37 (good)

ubuntu-electron-37.mov

Copy link
Copy Markdown
Contributor

@gzdunek gzdunek Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, we can merge it. Hopefully, the bug will be fixed by the time we release v19.

Copy link
Copy Markdown
Member

@ravicious ravicious Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created an issue here. electron/electron#48737

Copy link
Copy Markdown
Member

@ravicious ravicious Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it turns out that this is just how things will be on Linux from now on, so we have to live with the fact that app.focus() now works similar to Windows there. I updated the Electron update checklist so that it's something we expect.

Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"@grpc/grpc-js": "1.14.0",
"@types/which": "^3.0.4",
"node-forge": "^1.3.1",
"node-pty": "1.1.0-beta34",
"node-pty": "1.1.0-beta35",
"ring-buffer-ts": "^1.2.0",
"split2": "4.2.0",
"strip-ansi": "^7.1.2",
Expand All @@ -45,7 +45,7 @@
"@types/whatwg-url": "^13.0.0",
"@xterm/addon-fit": "^0.10.0",
"@xterm/xterm": "^5.5.0",
"electron": "37.4.0",
"electron": "38.2.1",
"electron-builder": "^26.0.12",
"electron-updater": "^6.6.8",
"electron-vite": "^4.0.1",
Expand Down
Loading