Bump electron from 37.4.0 to 38.2.1#59812
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
f18cf5f to
5b4cb64
Compare
There was a problem hiding this comment.
Tag builds:
- https://github.com/gravitational/teleport.e/actions/runs/18199997135
- Failed because of outdated node-abi
- https://github.com/gravitational/teleport.e/actions/runs/18217437402
- Some random failures unrelated to Electron
- https://github.com/gravitational/teleport.e/actions/runs/18320940831
- Teleport tarball failure with no logs
- https://github.com/gravitational/teleport.e/actions/runs/18350591390
There was a problem hiding this comment.
@gzdunek So this update works, almost. It breaks window focus on Ubuntu and Fedora. Instead of focusing on the window, it shows a system notification saying "Teleport Connect is ready". I confirmed that this is broken by the Electron update and not recent changes to window management – it works fine on master.
I haven't found an issue related to the focus problem. I can create it, but I think for now we can merge the update? The window doesn't get focus, but at least there's the notification.
Another thing is that because of electron/electron#48321, when running it in a Fedora VM I had to start the app twice because the initial start doesn't show the app window. This should be the case only in VMs.
Screen recordings
Electron 38 (bad)
ubuntu-electron-38.mov
Electron 37 (good)
ubuntu-electron-37.mov
There was a problem hiding this comment.
Agree, we can merge it. Hopefully, the bug will be fixed by the time we release v19.
There was a problem hiding this comment.
Well, it turns out that this is just how things will be on Linux from now on, so we have to live with the fact that app.focus() now works similar to Windows there. I updated the Electron update checklist so that it's something we expect.
Bumps [electron](https://github.com/electron/electron) from 37.4.0 to 38.2.0. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v37.4.0...v38.2.0) --- updated-dependencies: - dependency-name: electron dependency-version: 38.2.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
7d2a6b0 to
7ddf387
Compare
There was a problem hiding this comment.
Agree, we can merge it. Hopefully, the bug will be fixed by the time we release v19.
* Bump electron from 37.4.0 to 38.2.0 Bumps [electron](https://github.com/electron/electron) from 37.4.0 to 38.2.0. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v37.4.0...v38.2.0) --- updated-dependencies: - dependency-name: electron dependency-version: 38.2.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Revert unnecessary updates * Update node-pty to 1.1.0-beta35 * Update node-abi * Bump electron to 38.2.1 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rafał Cieślak <rafal.cieslak@goteleport.com>
* Bump electron from 37.4.0 to 38.2.0 Bumps [electron](https://github.com/electron/electron) from 37.4.0 to 38.2.0. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v37.4.0...v38.2.0) --- updated-dependencies: - dependency-name: electron dependency-version: 38.2.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Revert unnecessary updates * Update node-pty to 1.1.0-beta35 * Update node-abi * Bump electron to 38.2.1 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rafał Cieślak <rafal.cieslak@goteleport.com>
* Bump electron from 37.4.0 to 38.2.0 Bumps [electron](https://github.com/electron/electron) from 37.4.0 to 38.2.0. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v37.4.0...v38.2.0) --- updated-dependencies: - dependency-name: electron dependency-version: 38.2.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Revert unnecessary updates * Update node-pty to 1.1.0-beta35 * Update node-abi * Bump electron to 38.2.1 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rafał Cieślak <rafal.cieslak@goteleport.com>
Electron 38 drops support for macOS 11. This means we cannot backport it to v18 and older release branches, at least not straight away. Fortunately, Go 1.25 also dropped support for macOS 11 (#59104), so with v19 we'll just make it so that our clients require macOS 12+.
Down the line we might backport Go 1.25 to v18 and we can backport Electron's update at that point as well. See the discussion on Slack.
Original PR body
Bumps electron from 37.4.0 to 38.2.0.
Release notes
Sourced from electron's releases.
... (truncated)
Commits
81db417fix: MacOS 26 Tahoe - stop overriding private cornerMask API to fix WindowSer...5dfeee6fix: disable NSAutoFillHeuristicController on macOS 26 (#48394)2982cd7test: rerun failed tests individually (#48387)3179f61fix: set ozone platform for wayland (#48309)526dfe2build: update build tools to get siso for forks fix (#48345) (#48350)cf9d044feat: addfileSystemtoses.setPermissionCheckHandler(#48327)99feff3docs: mentionsetContentProtectionmacOS limitations (#48367)d60ae17chore: cherry-pick ec6c18478382 from v8 (#48337)f43348eci: Use Local Execution, Remote Caching (LERC) for fork PRS (#48323)5e51c88chore: bump chromium to 140.0.7339.133 (38-x-y) (#48287)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)