Conversation
zmb3
added
the
no-changelog
public-teleport-github-review-bot
bot
removed the request for review
from rudream
|
This is using the Go 1.25 synctest API, so it won't merge as-is. I'll hold it open for a bit and if we continue to be disrupted by the flakiness on release branches I'll make it compatible with Go 1.24, otherwise we'll just have the new tests going forward on master. |
Is it possibles to upgrade to go 1.25 on v18? i started writing some tests in synctest as well that needs to be backported 😭 |
We already have some tests using go 1.24 experimental synctest env var and build constrain |
i know. but we have manually move new tests to a different file and change synctest function . |
TestNotifications has been flaky, and I suspect part of it is due to the way we handle time. Notifications use UUIDv7, which include a timestamp, so our tests were mixing a fake clock and a real clock. This commit tests notifications using synctest without a fake clock in sight. Additionally, TestNotifications was testing too many things (pagination, matching, RBAC, state mutation, etc). This commit breaks the test up into several more-focused tests. Updates #58392
zmb3
force-pushed
the
bot/backport-59414-branch/v18
branch
from
4046a2e to
a3cee56
Compare
3 participants
Backport #59414 to branch/v18