Conversation
zmb3
added
the
no-changelog
greedy52
approved these changes
Sep 22, 2025
rudream
approved these changes
Sep 25, 2025
public-teleport-github-review-bot
bot
removed the request for review
from kiosion
TestNotifications has been flaky, and I suspect part of it is due to the way we handle time. Notifications use UUIDv7, which include a timestamp, so our tests were mixing a fake clock and a real clock. This commit tests notifications using synctest without a fake clock in sight. Additionally, TestNotifications was testing too many things (pagination, matching, RBAC, state mutation, etc). This commit breaks the test up into several more-focused tests. Updates #58392
zmb3
force-pushed
the
zmb3/test-notifications
branch
from
94a4105 to
ef09b50
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
This was referenced Sep 26, 2025
rhammonds-teleport
pushed a commit
that referenced
this pull request
Nov 6, 2025
TestNotifications has been flaky, and I suspect part of it is due to the way we handle time. Notifications use UUIDv7, which include a timestamp, so our tests were mixing a fake clock and a real clock. This commit tests notifications using synctest without a fake clock in sight. Additionally, TestNotifications was testing too many things (pagination, matching, RBAC, state mutation, etc). This commit breaks the test up into several more-focused tests. Updates #58392
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestNotifications has been flaky, and I suspect part of it is due to the way we handle time. Notifications use UUIDv7, which include a timestamp, so our tests were mixing a fake clock and a real clock.
This commit tests notifications using synctest without a fake clock in sight.
Additionally, TestNotifications was testing too many things (pagination, matching, RBAC, state mutation, etc). This commit breaks the test up into several more-focused tests.
Updates #58392