Conversation
Joerger
added
the
no-changelog
zmb3
approved these changes
Sep 25, 2025
espadolini
approved these changes
Sep 26, 2025
public-teleport-github-review-bot
bot
removed request for
marcoandredinis and
r0mant
zmb3
deleted the
joerger/replace-flaky-test-RecordingModesSessionTrackers
branch
Joerger
added a commit
that referenced
this pull request
Sep 29, 2025
Joerger
added a commit
that referenced
this pull request
Sep 29, 2025
Joerger
added a commit
that referenced
this pull request
Sep 29, 2025
This was referenced Sep 29, 2025
rhammonds-teleport
pushed a commit
that referenced
this pull request
Nov 6, 2025
Joerger
added a commit
that referenced
this pull request
Nov 11, 2025
Joerger
added a commit
that referenced
this pull request
Nov 17, 2025
Joerger
added a commit
that referenced
this pull request
Nov 24, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 3, 2025
* Fix discrepancies between Node and Proxy recording modes. (#58707) * Replace flaky test with more straightforward event metadata test. (#59610) * Make SSH session client provide session params upfront rather than with synchronous `envs@goteleport.com` requests (#59206) * Coordinate session ID with Node in Proxy recording mode (#59850) * Generalize PrepareToReceiveSessionID. * Initialize session ID in the connection context and update it from node current-session-id request. * Add session-id-query-v2@goteleport.com request and ensure new session ID is correctly set in proxy recording mode during the channel request. * Replace PrepareToReceiveSessionID with simpler in-place logic. * Don't emit session events or tracker when proxy forwarding to a Teleport Node. * Fix missing session tracker for outdated Teleport Node. * Remove extra major version grace period. * Update integration test. * Cleanup current session ID handling and fix failing tests. * Fix tests. * Address comments. * Restructure currentSessionID handling. * Set newSessionID in test server context. * Fix integration test. * Fix AuditOn integration test. * Address comment on channel close. * Track session on forwarding node. * Fix web shutdown. * Fix nil pointer dereference in test. * Fix test flake. * Fix nil pointer in test. * Fix test flake. * Update lib/srv/ctx.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Forwarding Node accepts client connection after receiving preparing session ID from node. This way, the forwarder can reject client connections if there is an issue preparing the session ID (impossible join sessions). * Remove check for session.data event which may not be emitted in time for the test. * Address comments. --------- Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> --------- Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the flaky integration test added in #58707 with a more straightforward test focused on the intended behavioral change from that PR.
Will be manually backported into #59599, #59600, #59601
Fixes #59586