[v18] Fix discrepancies between Node and Proxy recording modes.#59599
[v18] Fix discrepancies between Node and Proxy recording modes.#59599Joerger wants to merge 2 commits intobranch/v18from
Conversation
* Fix usage of node server ID and proxy host UUID in the forwarding server. * Make GetInfo and TargetMetadata consistent between the forwarding and regular server. * Rename TargetMetadata to EventMetadata and only use it for events' ServerMetadata. * Remove unused method. * Resolves comments on test. * Remove unused fields. * Update lib/srv/ctx.go Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * Update integration/integration_test.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
Joerger
added
the
no-changelog
integration/integration_test.go
Outdated
| t.Run("PAM", suite.bind(testPAM)) | ||
| t.Run("PortForwarding", suite.bind(testPortForwarding)) | ||
| t.Run("ProxyHostKeyCheck", suite.bind(testProxyHostKeyCheck)) | ||
| t.Run("RecordingModesSessionTrackers", suite.bind(testRecordingModesSessionTrackers)) |
There was a problem hiding this comment.
This test looks to be flaky on master. Should we fix before backporting?
There was a problem hiding this comment.
I've been bit by the test flake 2-3 times this afternoon, so I do think we want to fix this before merging, otherwise we could hold up merging any changes to release branches.
|
Sorry for the delay, @Joerger. I'm a little hesitant about these backports after the outage we had last week and need to find the time to take a closer look. What amount of testing have we done on this? |
No worries, fair hesitation. I've tested between Proxy/Nodes in different recording modes and some testing between different versions. I'll take some time to formally manually test each combination as well as test it in Teleport Cloud this week. |
|
Replaced by #61246 |
3 participants
Backport #58707, #59610 to branch/v18