[v17] Improve the dynamic Windows desktop reconciler#58062
Merged
zmb3 merged 1 commit intobranch/v17from Aug 19, 2025
Merged
Conversation
github-actions
bot
requested review from
danielashare,
probakowski,
rhammonds-teleport and
rosstimothy
rosstimothy
approved these changes
Aug 19, 2025
probakowski
approved these changes
Aug 19, 2025
public-teleport-github-review-bot
bot
removed request for
danielashare and
rhammonds-teleport
zmb3
force-pushed
the
zmb3/v17-backport-57724
branch
2 times, most recently
from
515a9e3 to
ccbc9e1
Compare
The reconciler runs in the Windows desktop service, watching for dynamic_windows_desktop resources that match its configured labels, and creating corresponding windows_desktop resources for any matches. This change makes several improvements to the reconciler: - emit a debug-level log entry showing how long the reconciliation took - move more state into local variables in the reconciler goroutine - ensure that we hit the local process cache instead of the backend - remove a suspicious delete operation that seems to be unnecessary at best and actively harmful at worst Co-authored-by: Tim Ross <tim.ross@goteleport.com>
zmb3
force-pushed
the
zmb3/v17-backport-57724
branch
from
ccbc9e1 to
0811056
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reconciler runs in the Windows desktop service, watching for dynamic_windows_desktop resources that match its configured labels, and creating corresponding windows_desktop resources for any matches.
This change makes several improvements to the reconciler:
Backports #57724
Changelog: Fixed an issue that could cause some hosts not to register dynamic Windows desktops.