Improve the dynamic Windows desktop reconciler#57724
Merged
Conversation
rosstimothy
reviewed
Aug 8, 2025
zmb3
force-pushed
the
zmb3/dynamic-desktop
branch
from
d50294f to
2d998f7
Compare
zmb3
force-pushed
the
zmb3/dynamic-desktop
branch
3 times, most recently
from
89d567d to
7a082fe
Compare
zmb3
commented
Aug 18, 2025
Comment on lines
-391
to
-397
| maps.DeleteFunc(currentResources, func(_ string, v types.WindowsDesktop) bool { | ||
| d, err := s.cfg.AuthClient.GetWindowsDesktops(ctx, types.WindowsDesktopFilter{ | ||
| HostID: v.GetHostID(), | ||
| Name: v.GetName(), | ||
| }) | ||
| return err != nil || len(d) == 0 | ||
| }) |
Collaborator
Author
There was a problem hiding this comment.
This was the problematic code. The rest of the changes in the PR are subtle improvements.
rhammonds-teleport
approved these changes
Aug 19, 2025
danielashare
approved these changes
Aug 19, 2025
probakowski
approved these changes
Aug 19, 2025
public-teleport-github-review-bot
bot
removed the request for review
from vapopov
The reconciler runs in the Windows desktop service, watching for dynamic_windows_desktop resources that match its configured labels, and creating corresponding windows_desktop resources for any matches. This change makes several improvements to the reconciler: - emit a debug-level log entry showing how long the reconciliation took - move more state into local variables in the reconciler goroutine - ensure that we hit the local process cache instead of the backend - remove a suspicious delete operation that seems to be unnecessary at best and actively harmful at worst Co-authored-by: Tim Ross <tim.ross@goteleport.com>
zmb3
force-pushed
the
zmb3/dynamic-desktop
branch
from
7a082fe to
7f25446
Compare
Contributor
This was referenced Aug 19, 2025
mmcallister
pushed a commit
that referenced
this pull request
Sep 22, 2025
The reconciler runs in the Windows desktop service, watching for dynamic_windows_desktop resources that match its configured labels, and creating corresponding windows_desktop resources for any matches. This change makes several improvements to the reconciler: - emit a debug-level log entry showing how long the reconciliation took - move more state into local variables in the reconciler goroutine - ensure that we hit the local process cache instead of the backend - remove a suspicious delete operation that seems to be unnecessary at best and actively harmful at worst Co-authored-by: Tim Ross <tim.ross@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fixed an issue that could cause some hosts not to register dynamic Windows desktops.