Fix condition that guards conversion of gateway into kube gateway#58032
Merged
Fix condition that guards conversion of gateway into kube gateway#58032
Conversation
rosstimothy
approved these changes
Aug 19, 2025
ravicious
approved these changes
Aug 19, 2025
| kubeGw, err := gateway.AsKube(gw) | ||
| if err != nil { | ||
| s.cfg.Logger.ErrorContext(ctx, "Could not clear certs for kube when assuming request", "error", err, "target_uri", targetURI) | ||
| return trace.Wrap(err) |
Member
There was a problem hiding this comment.
Why change the semantics here though?
Contributor
Author
There was a problem hiding this comment.
- We forgot to stop execution if the error is not nil, instead we log and still call the method which causes panic.
- If this error happens, it's not really a problem with clearing certs, but rather with converting one type to another which should not happen. It means a more serious issue, so I think we should surface it to the user.
Member
There was a problem hiding this comment.
Thanks, that makes total sense.
taraspos
approved these changes
Aug 19, 2025
Contributor
mmcallister
pushed a commit
that referenced
this pull request
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #54410 the condition
has been changed to
It unfortunately has a different meaning - if the target is not a kube URI but still belongs to the current cluster, the new condition would not return early, whereas the original condition would.
changelog: Fixed a Teleport Connect crash that occurred when assuming an access request while an application or database connection was active