Merged
Conversation
rosstimothy
added
the
no-changelog
rosstimothy
force-pushed
the
tross/golangci-lint-v2
branch
3 times, most recently
from
37f521f to
0ff2b43
Compare
This was referenced May 1, 2025
Contributor
Author
|
Note that since v2 is not compatible with the v1 config, I've preemptively opened backports and resolved issues for all release branches. My intent is to land them all at roughly the same time to minimize disruptions caused by needing to use different versions of the tool on different release branches. |
rosstimothy
requested review from
camscale,
fheinecke,
klizhentas,
r0mant,
russjones,
tcsc and
zmb3
as code owners
github-actions
bot
requested review from
boxofrad,
fspmarshall,
greedy52,
hugoShaka,
marcoandredinis,
nklaassen,
strideynet and
tigrato
github-actions
bot
added
application-access
audit-log
strideynet
approved these changes
May 6, 2025
rosstimothy
force-pushed
the
tross/golangci-lint-v2
branch
from
0ff2b43 to
b2e714f
Compare
public-teleport-github-review-bot
bot
removed request for
boxofrad,
fspmarshall,
greedy52 and
nklaassen
zmb3
approved these changes
May 7, 2025
rosstimothy
force-pushed
the
tross/golangci-lint-v2
branch
from
b2e714f to
a3fc413
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the golangci-lint config file to use v2 and bumps the version of golangci-lint used in CI to v2.1.5. Most issues found by the updated linter were addressed in the last commit,
QF1008was added to the ignore list due to the volume of preexisting violations.Depends on https://github.com/gravitational/teleport.e/pull/6436.